-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): implement engine core distribute liquid #17577
Open
sanni-t
wants to merge
11
commits into
edge
Choose a base branch
from
AUTH-1067-implement_engine_core_distribute_liquid
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17577 +/- ##
===========================================
- Coverage 63.08% 25.65% -37.44%
===========================================
Files 2840 2840
Lines 218766 218568 -198
Branches 18142 17944 -198
===========================================
- Hits 138010 56067 -81943
- Misses 80564 162486 +81922
+ Partials 192 15 -177
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AUTH-1067
Overview
Implements the
InstrumentCore.distribute_liquid()
methodTest Plan and Hands on Testing
Changelog
InstrumentCore.distribute_liquid()
InstrumentCore.dispense_liquid_class_during_multi_dispense()
to handle dispenses when doing a multi-dispenseTransferComponentsExecutor.retract_during_multi_dispensing()
Review requests
Risk assessment
Medium-Low. Doesn't change any existing public features but does modify small parts of the liquid-class based transfer & consolidate steps.