Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): implement engine core distribute liquid #17577

Open
wants to merge 11 commits into
base: edge
Choose a base branch
from

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Feb 24, 2025

Closes AUTH-1067

Overview

Implements the InstrumentCore.distribute_liquid() method

Test Plan and Hands on Testing

  • Added unit and integration tests
  • Analyzing different configurations in app
    • Distribute with per dest volume > tip max volume
    • Distribute with per dest volume < (tip max volume)/2
    • Distribute with per dest volume < (tip max volume)/2 but without multi-dispense properties
    • Distribute without consolidate volume
    • Distribute without disposal volume
  • Testing on Flex

Changelog

  • Added the implementation of InstrumentCore.distribute_liquid()
  • Added new InstrumentCore.dispense_liquid_class_during_multi_dispense() to handle dispenses when doing a multi-dispense
  • Added new TransferComponentsExecutor.retract_during_multi_dispensing()

Review requests

  • Code sanity and readability
  • Any cases I haven't implemented or called out in TODOs?

Risk assessment

Medium-Low. Doesn't change any existing public features but does modify small parts of the liquid-class based transfer & consolidate steps.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.65%. Comparing base (16d00ac) to head (7d2b65c).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17577       +/-   ##
===========================================
- Coverage   63.08%   25.65%   -37.44%     
===========================================
  Files        2840     2840               
  Lines      218766   218568      -198     
  Branches    18142    17944      -198     
===========================================
- Hits       138010    56067    -81943     
- Misses      80564   162486    +81922     
+ Partials      192       15      -177     
Flag Coverage Δ
app 3.42% <ø> (-43.18%) ⬇️
protocol-designer 18.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1519 files with indirect coverage changes

@sanni-t sanni-t marked this pull request as ready for review February 25, 2025 21:20
@sanni-t sanni-t requested a review from a team as a code owner February 25, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant