refactor(shared-data): Disallow empty labware geometries #17580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In labware schema v3:
Some definitions were providing a well geometry, but with an empty list of sections. This was adding an edge case to the tests and production code. This PR forbids that, so geometries either need to have real data, or they need to be omitted.
Test Plan and Hands on Testing
Just automated tests.
Changelog
sections
array to have at least one element.definitions/3/opentrons_24_aluminumblock_generic_2ml_screwcap/3.json
definitions/3/opentrons_24_tuberack_generic_0.75ml_snapcap_acrylic/2.json
definitions/3/opentrons_40_aluminumblock_eppendorf_24x2ml_safelock_snapcap_generic_16x0.2ml_pcr_strip/2.json
definitions/3/opentrons_96_aluminumblock_generic_pcr_strip_200ul/3.json
definitions/3/opentrons_24_tuberack_eppendorf_2ml_safelock_snapcap_acrylic/2.json
. This labware is very old, apparently predating the 4-in-1 tube rack set. It does not appear in Labware Library and does not have geometry measurements in the "LLD GEOMETRY LIBRARY" sheet. I think it's safe to say we're never going to care about getting good geometry info for it. I think it's questionable whether a schema 3 definition should exist for it at all, let alone one withinnerLabwareGeometry
.Review requests
Does my thinking in the changelog above sound correct?
Risk assessment
Low.