feat(api): simulate liquid probe results #17582
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In implementing liquid probing, we implemented a placeholder for simulating
liquid_probe_in_place
, where we just return the top position of a well unconditionally. This is fine for testingaspirate
, but causes a problem if you want to dispense, or really simulate a realistic chain of liquid handling actions.This code changes that simulated liquid probe so that it returns
"SimulatedProbeResult"
, and passes that into the protocol engine. This subsequently also requires a bunch of checks where pipette-related move-planning is done in the engine to see if values are floats or thisSimulatedProbeResult
Literal.Changelog
VirtualPipettingHandler::liquid_probe_in_place
return"SimulatedProbeResult"
instead of well depthSimulatedType
inupdate_types
(I'm not sure if this is necessary lmk please)SimulatedProbeResult
alsoTest Plan
edge
edge