Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(shared-data): Do not issue new schema-3 versions of legacy labware definitions #17585

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Feb 25, 2025

Overview

When we were setting up labware schema 3, we carried forward a bunch of labware definitions from labware schema 2. Some of those definitions seem legacy/deprecated to me. This PR deletes those for maintainability. This makes it easier for us to keep the dimensions in sync with the latest values from the hardware team.

Test Plan and Hands on Testing

None.

Changelog

Delete the schema 3 files for "combined adapter + labware" definitions. These have been superseded by labware stacking. For example, opentrons_96_aluminumblock_biorad_wellplate_200ul has been superseded by opentrons_96_aluminumblock + biorad_96_wellplate_200ul_pcr.

  • opentrons_96_aluminumblock_biorad_wellplate_200ul
  • opentrons_96_aluminumblock_nest_wellplate_100ul
  • opentrons_96_deep_well_adapter_nest_wellplate_2ml_deep
  • opentrons_96_flat_bottom_adapter_nest_wellplate_200ul_flat
  • opentrons_96_pcr_adapter_armadillo_wellplate_200ul
  • opentrons_96_pcr_adapter_nest_wellplate_100ul_pcr_full_skirt
  • opentrons_universal_flat_adapter_corning_384_wellplate_112ul_flat

Delete the schema 3 files for some labware that are apparently very old and physically discontinued (source). These do not appear in Labware Library and do not have geometry measurements in the "LLD GEOMETRY LIBRARY" sheet.

  • opentrons_10_tuberack_falcon_4x50ml_6x15ml_conical_acrylic
  • opentrons_24_tuberack_eppendorf_2ml_safelock_snapcap_acrylic
  • opentrons_24_tuberack_generic_0.75ml_snapcap_acrylic
  • opentrons_40_aluminumblock_eppendorf_24x2ml_safelock_snapcap_generic_16x0.2ml_pcr_strip

The old schema 2 files remain in place, so these labware are still usable in protocols. They just won't benefit from schema 3 positioning improvements.

Review requests

  • Any that I missed?
  • Any that should not be deleted?

Risk assessment

Low. None of these schema 3 labware definitions have been released yet.

@SyntaxColoring SyntaxColoring marked this pull request as ready for review February 25, 2025 22:52
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner February 25, 2025 22:52
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.08%. Comparing base (16d00ac) to head (20c945c).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17585   +/-   ##
=======================================
  Coverage   63.08%   63.08%           
=======================================
  Files        2840     2840           
  Lines      218766   218766           
  Branches    18142    18142           
=======================================
  Hits       138010   138010           
  Misses      80564    80564           
  Partials      192      192           
Flag Coverage Δ
protocol-designer 18.86% <ø> (ø)
step-generation 4.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant