Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol-designer) add components folder for atoms/molecules/organisms #17733

Merged
merged 8 commits into from
Mar 13, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 12, 2025

Overview

This PR is for the phase-1 of refactoring protocol-designer.

  • add components folder for atoms/molecules/organisms
  • add a couple of atoms components to index.ts to export them
  • add hooks folder in resources

close AUTH-1547

Test Plan and Hands on Testing

smoke test

Changelog

Review requests

Risk assessment

low

koji added 2 commits March 12, 2025 10:18
…s/organisms

add components folder for atoms/molecules/organisms

close AUTH-
@koji koji requested review from ncdiehl11, jerader and syao1226 March 12, 2025 14:23
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 32 lines in your changes missing coverage. Please review.

Project coverage is 59.87%. Comparing base (2d02c78) to head (8209eb0).
Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...organisms/TipPositionModal/TipPositionSideView.tsx 0.00% 9 Missing ⚠️
.../organisms/TipPositionModal/TipPositionTopView.tsx 0.00% 9 Missing ⚠️
...rganisms/TipPositionModal/TipPositionZOnlyView.tsx 0.00% 9 Missing ⚠️
...ents/organisms/AnnouncementModal/announcements.tsx 0.00% 4 Missing ⚠️
protocol-designer/src/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17733       +/-   ##
===========================================
+ Coverage   25.11%   59.87%   +34.76%     
===========================================
  Files        2860     2917       +57     
  Lines      220382   224536     +4154     
  Branches    18642    19059      +417     
===========================================
+ Hits        55348   134444    +79096     
+ Misses     165024    89907    -75117     
- Partials       10      185      +175     
Flag Coverage Δ
opentrons-ai-client ?
protocol-designer 18.79% <50.00%> (-0.01%) ⬇️
shared-data ?
step-generation 4.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
protocol-designer/src/ProtocolEditor.tsx 0.00% <ø> (ø)
protocol-designer/src/ProtocolRoutes.tsx 0.00% <ø> (ø)
...designer/src/components/atoms/GlobalStyle/index.ts 100.00% <ø> (ø)
...esigner/src/components/atoms/HandleEnter/index.tsx 100.00% <ø> (ø)
...col-designer/src/components/atoms/Toggle/index.tsx 43.33% <ø> (ø)
...signer/src/components/atoms/ToggleButton/index.tsx 100.00% <ø> (ø)
...rotocol-designer/src/components/atoms/constants.ts 100.00% <ø> (ø)
protocol-designer/src/components/atoms/index.ts 100.00% <100.00%> (ø)
...ts/molecules/CheckboxExpandStepFormField/index.tsx 3.44% <ø> (ø)
...mponents/molecules/CheckboxStepFormField/index.tsx 5.26% <ø> (ø)
... and 163 more

... and 1710 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as ready for review March 12, 2025 15:25
@koji koji requested a review from a team as a code owner March 12, 2025 15:25
@koji koji removed the request for review from a team March 12, 2025 15:26
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i smoke tested and did not run into any issues. This can merge after you address the merge conflict. Thanks for doing this!

Also, once this merges, can you post about it in slack so other devs working on PD are aware of this reorganization? I know we want to talk more about it during the front-end guild but probably good to give a quick heads up to PD devs.

@koji koji merged commit 521f568 into edge Mar 13, 2025
40 checks passed
@koji koji deleted the refactor_protocol-designer-phase-1 branch March 13, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants