-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(protocol-designer) add components folder for atoms/molecules/organisms #17733
Conversation
…s/organisms add components folder for atoms/molecules/organisms close AUTH-
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17733 +/- ##
===========================================
+ Coverage 25.11% 59.87% +34.76%
===========================================
Files 2860 2917 +57
Lines 220382 224536 +4154
Branches 18642 19059 +417
===========================================
+ Hits 55348 134444 +79096
+ Misses 165024 89907 -75117
- Partials 10 185 +175
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, i smoke tested and did not run into any issues. This can merge after you address the merge conflict. Thanks for doing this!
Also, once this merges, can you post about it in slack so other devs working on PD are aware of this reorganization? I know we want to talk more about it during the front-end guild but probably good to give a quick heads up to PD devs.
Overview
This PR is for the phase-1 of refactoring protocol-designer.
hooks
folder inresources
close AUTH-1547
Test Plan and Hands on Testing
smoke test
Changelog
Review requests
Risk assessment
low