refactor(step-generation): getTrashBinAddressableAreaName to always r…

[jerader]

…eturn AddressableAreaName

Overview

Slight refactor so that the getTrashBinAddressableAreaName util always returns AddressableAreaName and never null to help with py interop

Test Plan and Hands on Testing

Review the code. functionality should remain the same

Changelog

• refactor getTrashBinAddressableAreaName to not return null
• refactor affected usages of the util to grab the trash location in the parent component

Risk assessment

low, should maintain current functionality

[codecov]

Codecov Report

Attention: Patch coverage is 58.49057% with 22 lines in your changes missing coverage. Please review.

Project coverage is 61.93%. Comparing base (e792062) to head (21473db).
Report is 30 commits behind head on edge.

Files with missing lines	Patch %	Lines
...p-generation/src/utils/movableTrashCommandsUtil.ts	50.00%	15 Missing ⚠️
step-generation/src/utils/misc.ts	50.00%	4 Missing ⚠️
...ion/src/commandCreators/compound/dropTipInTrash.ts	62.50%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             edge   #17741      +/-   ##
==========================================
- Coverage   61.93%   61.93%   -0.01%     
==========================================
  Files        2824     2823       -1     
  Lines      217106   217121      +15     
  Branches    18437    18439       +2     
==========================================
+ Hits       134458   134465       +7     
- Misses      82463    82471       +8     
  Partials      185      185              

Flag	Coverage Δ
protocol-designer	18.84% <30.18%> (-0.01%)	⬇️
step-generation	4.35% <45.28%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...c/timelineMiddleware/generateRobotStateTimeline.ts	87.38% <100.00%> (+0.47%)	⬆️
...ion/src/commandCreators/compound/dropTipInTrash.ts	92.68% <62.50%> (-4.62%)	⬇️
step-generation/src/utils/misc.ts	88.40% <50.00%> (+0.20%)	⬆️
...p-generation/src/utils/movableTrashCommandsUtil.ts	67.59% <50.00%> (-3.69%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ddcc4]

Hey, thanks for doing this, but I'm not sure if it helps much after seeing this code. I was hoping that we'd be able to find a way to skip the == null check entirely. I don't think this change makes the code any simpler or shorter.

[jerader]

yeah i agree... we shouldn't see trashLocation == null so i could remove the console.error but i don't feel comfortable doing that until we reexamine fixing the location type

[jerader]

closing this PR in place of this: #17774