-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, shared-data): add liquid classes form warnings #17765
Open
syao1226
wants to merge
16
commits into
edge
Choose a base branch
from
pd-form-error-handling
base: edge
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17765 +/- ##
===========================================
- Coverage 62.55% 24.68% -37.87%
===========================================
Files 2888 3032 +144
Lines 222555 235260 +12705
Branches 18724 20469 +1745
===========================================
- Hits 139211 58076 -81135
- Misses 83155 177169 +94014
+ Partials 189 15 -174
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
koji
reviewed
Mar 19, 2025
koji
reviewed
Mar 19, 2025
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Mar 19, 2025
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Mar 19, 2025
koji
reviewed
Mar 19, 2025
ncdiehl11
reviewed
Mar 20, 2025
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Show resolved
Hide resolved
...c/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/LiquidClassesStepTools.tsx
Outdated
Show resolved
Hide resolved
jerader
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re AUTH-1530
Overview
This PR adds new form warnings to display any incompatible pipette, tip rack, transfer volume, and/or pipette path with liquid classes in the PD transfer step. It also disables incompatible liquid class options.
Design: https://www.figma.com/design/RcHb9UdygVtyXcvDcDmnTP/Feature%3A-Liquid-Classes?node-id=1833-28759&t=6C60uZBriQj1doAs-4
Test Plan and Hands on Testing
Changelog
-Updated the LiquidClassesStepTools to handle disabling incompatible liquid classes options
-Updated the warnings file to add
lowVolumeTransfer
,incompatiblePipettePath
,incompatibleAllPipetteLabware
, andincompatibleSomePipetteLabware
warnings.-Added a
PIPETTE_NAMES_MAP
to map pipette names to pipette load names-Added
getDisableLiquidClasses
to determines which liquid classes should be disabled based on the pipette model, tip rack, volume, and dispense path-Added
getIncompatibleLiquidClasses
returns a list of liquid class names that are incompatible based on a given predicate-Added tests
Review requests
Risk assessment