Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, shared-data): add liquid classes form warnings #17765

Open
wants to merge 16 commits into
base: edge
Choose a base branch
from

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Mar 14, 2025

re AUTH-1530

Overview

This PR adds new form warnings to display any incompatible pipette, tip rack, transfer volume, and/or pipette path with liquid classes in the PD transfer step. It also disables incompatible liquid class options.

Design: https://www.figma.com/design/RcHb9UdygVtyXcvDcDmnTP/Feature%3A-Liquid-Classes?node-id=1833-28759&t=6C60uZBriQj1doAs-4

Test Plan and Hands on Testing

  1. Create or import a protocol with a pipette and tip rack that are incompatible with one or more liquid classes
  2. Lower the transfer volume to be less than or equals to 10 µL
  3. Select a pipette path that's incompatible with one or more liquid classes (currently all paths are compatible)
  4. Verify that the warning messages align with the design and that the incompatible liquid class options are disabled when proceeding to the next page

Changelog

-Updated the LiquidClassesStepTools to handle disabling incompatible liquid classes options
-Updated the warnings file to add lowVolumeTransfer, incompatiblePipettePath, incompatibleAllPipetteLabware, and incompatibleSomePipetteLabware warnings.
-Added a PIPETTE_NAMES_MAP to map pipette names to pipette load names
-Added getDisableLiquidClasses to determines which liquid classes should be disabled based on the pipette model, tip rack, volume, and dispense path
-Added getIncompatibleLiquidClasses returns a list of liquid class names that are incompatible based on a given predicate
-Added tests

Review requests

Risk assessment

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 90.62500% with 21 lines in your changes missing coverage. Please review.

Project coverage is 24.68%. Comparing base (0d1ce63) to head (00a1a00).
Report is 23 commits behind head on edge.

Files with missing lines Patch % Lines
...tocol-designer/src/steplist/formLevel/warnings.tsx 86.07% 11 Missing ⚠️
shared-data/js/helpers/index.ts 80.85% 9 Missing ⚠️
...epTools/MoveLiquidTools/LiquidClassesStepTools.tsx 94.73% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #17765       +/-   ##
===========================================
- Coverage   62.55%   24.68%   -37.87%     
===========================================
  Files        2888     3032      +144     
  Lines      222555   235260    +12705     
  Branches    18724    20469     +1745     
===========================================
- Hits       139211    58076    -81135     
- Misses      83155   177169    +94014     
+ Partials      189       15      -174     
Flag Coverage Δ
protocol-designer 19.08% <90.62%> (+0.22%) ⬆️
shared-data 74.23% <ø> (-0.07%) ⬇️
step-generation 4.38% <1.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Steps/StepForm/StepTools/MoveLiquidTools/index.tsx 84.78% <100.00%> (+0.33%) ⬆️
protocol-designer/src/steplist/formLevel/index.ts 87.30% <100.00%> (-0.41%) ⬇️
...igner/src/steplist/formLevel/test/warnings.test.ts 100.00% <100.00%> (ø)
shared-data/js/constants.ts 100.00% <100.00%> (ø)
...epTools/MoveLiquidTools/LiquidClassesStepTools.tsx 99.11% <94.73%> (-0.89%) ⬇️
shared-data/js/helpers/index.ts 62.17% <80.85%> (+1.91%) ⬆️
...tocol-designer/src/steplist/formLevel/warnings.tsx 91.83% <86.07%> (-2.78%) ⬇️

... and 1851 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@syao1226 syao1226 requested review from ncdiehl11 and koji March 19, 2025 15:01
@syao1226 syao1226 marked this pull request as ready for review March 19, 2025 15:01
@syao1226 syao1226 requested review from a team as code owners March 19, 2025 15:01
@syao1226 syao1226 changed the title feat(protocol-designer): add liquid classes form warnings feat(protocol-designer, shared-data): add liquid classes form warnings Mar 19, 2025
@syao1226 syao1226 requested review from koji and ncdiehl11 March 21, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants