-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components, app): deprecated PipetteSelect #17769
base: edge
Are you sure you want to change the base?
Conversation
deprecated PipetteSelect since it's not used (pd-redesign) and app has its own component close AUTH-1573
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17769 +/- ##
==========================================
- Coverage 24.35% 20.97% -3.38%
==========================================
Files 2949 2952 +3
Lines 227263 229940 +2677
Branches 19137 19847 +710
==========================================
- Hits 55354 48236 -7118
- Misses 171899 181699 +9800
+ Partials 10 5 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
@@ -56,6 +56,9 @@ const specToOption = ({ | |||
label: displayName, | |||
}) | |||
|
|||
/** | |||
* @deprecated The component is no longer used and will be removed in a future release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait if this component is not in use, why not delete it now?
Overview
deprecated PipetteSelect since it's not used (pd-redesign) and app has its own component
close AUTH-1573
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low