Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components, app): deprecated PipetteSelect #17769

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 14, 2025

Overview

deprecated PipetteSelect since it's not used (pd-redesign) and app has its own component

close AUTH-1573

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

deprecated PipetteSelect since it's not used (pd-redesign) and app has its own component

close AUTH-1573
@koji koji marked this pull request as ready for review March 14, 2025 16:29
@koji koji requested a review from a team as a code owner March 14, 2025 16:29
@koji koji removed the request for review from a team March 14, 2025 16:30
@koji koji changed the title chore(components): deprecated PipetteSelect chore(components, app): deprecated PipetteSelect Mar 14, 2025
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 20.97%. Comparing base (a9d6b6f) to head (0e70315).
Report is 73 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/molecules/PipetteSelect/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17769      +/-   ##
==========================================
- Coverage   24.35%   20.97%   -3.38%     
==========================================
  Files        2949     2952       +3     
  Lines      227263   229940    +2677     
  Branches    19137    19847     +710     
==========================================
- Hits        55354    48236    -7118     
- Misses     171899   181699    +9800     
+ Partials       10        5       -5     
Flag Coverage Δ
app 0.35% <0.00%> (∅)
opentrons-ai-client ?
protocol-designer 19.37% <0.00%> (∅)
shared-data ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/instrument/index.ts 100.00% <ø> (ø)
app/src/molecules/PipetteSelect/index.tsx 0.00% <0.00%> (ø)

... and 361 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -56,6 +56,9 @@ const specToOption = ({
label: displayName,
})

/**
* @deprecated The component is no longer used and will be removed in a future release.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait if this component is not in use, why not delete it now?

@koji koji requested a review from jerader March 20, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants