chore(api): only auto liquid probe with clean tips #17808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster1
requested changes
Mar 19, 2025
There was a problem hiding this comment.
I see the intent with clean being part of the fluid state because it is sort of "empty but also never has been other than empty", but it's really confusing to have it in the fluid state and to have all the functions that it set it be like set_fluid_clean(). Can we break it out into its own boolean state please? That way we can have empty and clean, or empty and not clean.
We also probably should extend this to tracking the clean state of tips that have been returned, but I don't think we track tip return state at all in the engine so we can do that in another pr.
sfoster1
added
the
gen-analyses-snapshot-pr
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17840 |
…ean-tips snapshots (#17840) This PR was requested on the PR #17808 Co-authored-by: sfoster1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If a tip is "wet" it can trigger a false positive, or worse, pull up any remnant drops into the stem.
This adds a variant of the "empty" state of to the pipette state called "clean". When a tip is picked up it now marks it as "clean" instead of empty. This just sets the clean flag in the state and otherwise does the same thing as empty.
Any subsequent liquid action marks the "clean" state as false.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment