Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): py command for dropping tip in waste chute #17831

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 20, 2025

Overview

Generate the python command for dropping tip in a waste chute

Test Plan and Hands on Testing

Review the code and smoke test, should pass analysis

    # Load Waste Chute:
    waste_chute = protocol.load_waste_chute()

    # PROTOCOL STEPS

    # Step 1:
    pipette_left.pick_up_tip(location=tip_rack_1)
    pipette_left.configure_for_volume(10)
    pipette_left.aspirate(
        volume=10,
        location=well_plate_1["D12"].bottom(z=1),
        rate=35 / pipette_left.flow_rate.aspirate,
    )
    pipette_left.dispense(
        volume=10,
         location=well_plate_1["D12"].bottom(z=1),
        rate=57 / pipette_left.flow_rate.dispense,
    )

   pipette_left.drop_tip(waste_chute)

Changelog

  • add python generation to dropTipInWasteChute compound command and add test coverage

Risk assessment

low, shouldn't affect functionality

@jerader jerader requested a review from a team as a code owner March 20, 2025 15:43
@jerader jerader requested a review from ddcc4 March 20, 2025 15:43
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 23.42%. Comparing base (318145f) to head (76073c3).
Report is 4 commits behind head on edge.

Files with missing lines Patch % Lines
...c/timelineMiddleware/generateRobotStateTimeline.ts 0.00% 2 Missing ⚠️
...eration/src/commandCreators/compound/distribute.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17831      +/-   ##
==========================================
+ Coverage   23.40%   23.42%   +0.01%     
==========================================
  Files        2891     2891              
  Lines      222526   222573      +47     
  Branches    19010    19017       +7     
==========================================
+ Hits        52078    52127      +49     
+ Misses     170437   170435       -2     
  Partials       11       11              
Flag Coverage Δ
protocol-designer 18.85% <0.00%> (-0.02%) ⬇️
step-generation 4.39% <84.21%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ration/src/commandCreators/compound/consolidate.ts 95.64% <100.00%> (+0.01%) ⬆️
...rc/commandCreators/compound/dropTipInWasteChute.ts 97.61% <100.00%> (+0.56%) ⬆️
...eration/src/commandCreators/compound/replaceTip.ts 78.42% <100.00%> (+0.11%) ⬆️
...eneration/src/commandCreators/compound/transfer.ts 96.16% <100.00%> (+<0.01%) ⬆️
step-generation/src/index.ts 100.00% <ø> (ø)
...eration/src/commandCreators/compound/distribute.ts 94.60% <0.00%> (-0.21%) ⬇️
...c/timelineMiddleware/generateRobotStateTimeline.ts 88.63% <0.00%> (+3.21%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ddcc4
Copy link
Contributor

ddcc4 commented Mar 20, 2025

pipette_left.drop_tip()

Hey, I'd really like this to be drop_tip(waste_chute).

I would have also preferred dropping tips into the trash bin to be drop_tip(trash_bin), but I couldn't do that because "Starting with API version 2.18, the API will only vary the [trash bin] tip drop location if location is not specified." So I had to omit the trash_bin argument has a hacky workaround to make the API alternate the drop location. (And as I noted in the comments, this is super brittle because it would only work if the trash bin was the first thing loaded.)

But for the waste chute, there is no such thing as alternating the drop location. So we can just call drop_tip(waste_chute) like we intended.

@jerader jerader merged commit 5f383ef into edge Mar 20, 2025
18 checks passed
@jerader jerader deleted the pd_drop-tip-waste-chute branch March 20, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants