-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(step-generation): py command generation for mix() #17833
base: edge
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17833 +/- ##
===========================================
+ Coverage 23.41% 63.24% +39.83%
===========================================
Files 2891 2891
Lines 222561 223631 +1070
Branches 19013 19545 +532
===========================================
+ Hits 52115 141438 +89323
+ Misses 170435 82008 -88427
- Partials 11 185 +174
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
repetitions=2, | ||
volume=5, | ||
location=mockPythonName["A1"].bottom(z=3.2), | ||
rate=(2.1 / mockPythonName.flow_rate.aspirate) + (2.2 / mockPythonName.flow_rate.dispense), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to figure out how to show both flow rates or if we have to remove one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay discussed with jeremy in standup and actually we can just define it above the mix()
like this
mockPythonName.mix(
repetitions=2,
volume=5,
location=mockPythonName["C1"].bottom(z=3.2),
)
closes AUTH-1097
Overview
this PR introduces the py command generation for
mix()
! It is emitted only if there are acceptable args. Meaning no aspirate delay, no dispense delay.TODO: figure out the flow rates! user can specify both aspirate and dispense flow rates but mix can only use one. how do we know which one to use?
Test Plan and Hands on Testing
Review the code and smoke test
here is an example i made that passes analysis for the different variations of commands
Changelog
mix()
in the mixUtilRisk assessment
low, behind a ff