-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer,-shared-data): introduce push out field in PD #17835
Conversation
This PR introduces UI and form data for push out as a checkbox expand form field in moveLiquid -> dispense. Previously, push out volumes were not configurable by the user, and were added implicitly. In order to migrate older protocols, we need to grab their default pushouts from their pipette specs. The utility `getDefaultPushOutVolume` takes into account transfer volume in order to access the correct liquids properties (default or low volume). Closes AUTH-911
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17835 +/- ##
===========================================
+ Coverage 23.41% 63.57% +40.16%
===========================================
Files 2891 2891
Lines 222559 222952 +393
Branches 19013 19248 +235
===========================================
+ Hits 52112 141744 +89632
+ Misses 170436 81018 -89418
- Partials 11 190 +179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
wait so by default, when you create a new form, pushOut is null? so it would be using the default push out if the user never clicks on the checkbox? Wouldn't when they import their protocol back into PD, the checkbox would be selected? |
This won't be the case in practice. The only reason that field is null (empty) is because getting the liquid class push out volume for a given transfer is outside of the scope of this PR. A closed checkbox will evaluate to 0 pushout volume, which would respected when re-uploading. |
Got it, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No nits 😄 code is very organized and field and errors work as expected. thanks for writing the test cases for the utils!
Thank you for the prompt review! Excited to get this wired up finally |
Overview
This PR introduces UI and form data for push out as a checkbox expand form field in moveLiquid -> dispense. Previously, push out volumes were not configurable by the user, and were added implicitly. In order to migrate older protocols, we need to grab their default pushouts from their pipette specs. The utility
getDefaultPushOutVolume
takes into account transfer volume in order to access the correct liquids properties (default or low volume).Closes AUTH-911
Test Plan and Hands on Testing
new
migrated
shared-data/pipette/definitions/2/liquid
-> its definition to find itsdefaultPushOutVolume
Changelog
Review requests
see test plan. Please reach out if you have any questions on the logic of getting default or max push out volumes
Risk assessment
low