Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): py command for blowout in waste chute #17837

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 20, 2025

Overview

This PR generates the py command for blow_out() in a waste chute

Test Plan and Hands on Testing

Review code and smoke test. should pass analysis if blowing out in the waste chute.

Changelog

  • generate py command for blow out in a waste chute
  • add to unit test

Risk assessment

low, behind ff

@jerader jerader requested a review from a team as a code owner March 20, 2025 19:15
@jerader jerader requested a review from ddcc4 March 20, 2025 19:15
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.43%. Comparing base (7e44ff5) to head (877732d).
Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17837      +/-   ##
==========================================
+ Coverage   23.41%   23.43%   +0.02%     
==========================================
  Files        2891     2891              
  Lines      222559   222614      +55     
  Branches    19013    19047      +34     
==========================================
+ Hits        52112    52178      +66     
+ Misses     170436   170425      -11     
  Partials       11       11              
Flag Coverage Δ
protocol-designer 18.88% <0.00%> (+0.01%) ⬆️
step-generation 4.40% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/commandCreators/compound/blowOutInWasteChute.ts 100.00% <100.00%> (ø)
step-generation/src/utils/misc.ts 86.69% <100.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit f90d568 into edge Mar 21, 2025
24 checks passed
@jerader jerader deleted the sg_waste-chute-blowout-py branch March 21, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants