Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol-designer): consolidate CheckboxExapandStepFormFieldProps #17843

Draft
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

ncdiehl11
Copy link
Collaborator

Overview

This PR utilizes the existing propsForFields structure to pass all necessary fields to CheckboxExpandStepFormField for the implicated checkbox stepform field. Instead of individually passing values for the field props value, updateValue, isChecked, tooltipText, and disabled, we can simply pass that field's propsForFields, and destructure inside the checkbox expand component.

Test Plan and Hands on Testing

smoke test mix, moveLiquid, batchEditMix, batchEditMoveLiquid tools

Changelog

  • refactor CheckboxExpandStepFormField props and implement in stepform toolboxes

Review requests

see test plan

Risk assessment

low-ish

… props

This PR utilizes the existing `propsForFields` structure to pass all necessary fields to CheckboxExpandStepFormField for the implicated checkbox stepform field. Instead of indivisually passing values for the field props `value`, `updatValue`, `isChecked`, `tooltipText`, and `disabled`, we can simply pass that field's `propsForFields`, and destructure inside the checkbox expand component.
@ncdiehl11 ncdiehl11 self-assigned this Mar 20, 2025
@ncdiehl11 ncdiehl11 requested review from koji and jerader March 20, 2025 21:59
@ncdiehl11 ncdiehl11 marked this pull request as ready for review March 20, 2025 21:59
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner March 20, 2025 21:59
@ncdiehl11 ncdiehl11 removed the request for review from a team March 20, 2025 21:59
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 23.40%. Comparing base (68263e5) to head (9d812b0).
Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...ts/molecules/CheckboxExpandStepFormField/index.tsx 0.00% 10 Missing ⚠️
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.00% 8 Missing ⚠️
...teps/BatchEditToolbox/BatchEditMoveLiquidTools.tsx 0.00% 4 Missing ⚠️
...otocolSteps/BatchEditToolbox/BatchEditMixTools.tsx 0.00% 3 Missing ⚠️
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx 0.00% 3 Missing ⚠️
...ocolSteps/StepForm/PipetteFields/DisposalField.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17843      +/-   ##
==========================================
- Coverage   23.42%   23.40%   -0.02%     
==========================================
  Files        2891     2892       +1     
  Lines      222711   222895     +184     
  Branches    19018    19019       +1     
==========================================
+ Hits        52171    52173       +2     
- Misses     170529   170711     +182     
  Partials       11       11              
Flag Coverage Δ
protocol-designer 18.85% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ocolSteps/StepForm/PipetteFields/DisposalField.tsx 2.63% <0.00%> (+0.06%) ⬆️
...otocolSteps/BatchEditToolbox/BatchEditMixTools.tsx 1.49% <0.00%> (+0.08%) ⬆️
...rotocolSteps/StepForm/StepTools/MixTools/index.tsx 0.76% <0.00%> (+0.03%) ⬆️
...teps/BatchEditToolbox/BatchEditMoveLiquidTools.tsx 1.12% <0.00%> (+0.05%) ⬆️
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.75% <0.00%> (+0.05%) ⬆️
...ts/molecules/CheckboxExpandStepFormField/index.tsx 3.63% <0.00%> (+0.18%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncdiehl11 ncdiehl11 marked this pull request as draft March 20, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant