-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(step-generation): py commands for move_to well #17846
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17846 +/- ##
=======================================
Coverage 23.41% 23.42%
=======================================
Files 2892 2891 -1
Lines 222487 222493 +6
Branches 18934 18933 -1
=======================================
+ Hits 52104 52110 +6
Misses 170372 170372
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
}, | ||
}, | ||
]) | ||
expect(getSuccessResult(result).python).toBe( | ||
'mockPythonName.move_to(mockPythonName["A1"].bottom(z=1)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this missing a )
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yup, i didn't notice. good catch!
Overview
Py command for moving to a well with the
move_to()
api commandTest Plan and Hands on Testing
Review the code and smoke test
Changelog
moveToWell
and add test caseRisk assessment
low, doesn't affect functionality