Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): py commands for move_to well #17846

Merged
merged 4 commits into from
Mar 21, 2025
Merged

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 21, 2025

Overview

Py command for moving to a well with the move_to() api command

Test Plan and Hands on Testing

Review the code and smoke test

Changelog

  • generate python from moveToWell and add test case

Risk assessment

low, doesn't affect functionality

@jerader jerader requested a review from a team as a code owner March 21, 2025 16:12
@jerader jerader requested a review from ddcc4 March 21, 2025 16:12
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.42%. Comparing base (d72ee2c) to head (edf5c13).
Report is 2 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17846   +/-   ##
=======================================
  Coverage   23.41%   23.42%           
=======================================
  Files        2892     2891    -1     
  Lines      222487   222493    +6     
  Branches    18934    18933    -1     
=======================================
+ Hits        52104    52110    +6     
  Misses     170372   170372           
  Partials       11       11           
Flag Coverage Δ
protocol-designer 18.87% <11.11%> (-0.01%) ⬇️
step-generation 4.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
shared-data/command/types/index.ts 100.00% <100.00%> (ø)
...eneration/src/commandCreators/atomic/moveToWell.ts 94.01% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

},
},
])
expect(getSuccessResult(result).python).toBe(
'mockPythonName.move_to(mockPythonName["A1"].bottom(z=1)'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this missing a )?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yup, i didn't notice. good catch!

@jerader jerader merged commit 328df5f into edge Mar 21, 2025
51 checks passed
@jerader jerader deleted the pd_move-to-well-py branch March 21, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants