Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(step-generation): generate py command for moveToAddressableArea #17849

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Mar 21, 2025

Overview

This PR generates python command for moveToAddressableArea as move_to() for waste chute and trash bin. As a result, I had to refactor all the affected utils and compound commands because i needed to add a fixtureId arg in order to return the trash bin or waste chute python name.

Test Plan and Hands on Testing

Review the code. Had to do a bit of a refactor in order to get the correct args.

Changelog

  • generate the move_to() api command for moving to a waste chute or trash bin
  • refactor affects utils and compound commands to pass the fixture id as an arg
  • fix affected tests
  • add unit test for testing the py command

Risk assessment

low, shouldn't affect functionality

@jerader jerader requested a review from a team as a code owner March 21, 2025 16:42
@jerader jerader requested a review from ddcc4 March 21, 2025 16:42
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.41%. Comparing base (d72ee2c) to head (fcb6bae).

Files with missing lines Patch % Lines
step-generation/src/utils/misc.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17849      +/-   ##
==========================================
- Coverage   23.41%   23.41%   -0.01%     
==========================================
  Files        2892     2892              
  Lines      222487   222470      -17     
  Branches    18934    18936       +2     
==========================================
- Hits        52104    52095       -9     
+ Misses     170372   170364       -8     
  Partials       11       11              
Flag Coverage Δ
protocol-designer 18.87% <18.42%> (+<0.01%) ⬆️
step-generation 4.35% <89.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/commandCreators/atomic/moveToAddressableArea.ts 100.00% <100.00%> (ø)
...tion/src/commandCreators/compound/airGapInTrash.ts 100.00% <100.00%> (ø)
...src/commandCreators/compound/airGapInWasteChute.ts 100.00% <100.00%> (ø)
...ion/src/commandCreators/compound/blowOutInTrash.ts 100.00% <100.00%> (ø)
...rc/commandCreators/compound/blowOutInWasteChute.ts 100.00% <100.00%> (ø)
...on/src/commandCreators/compound/dispenseInTrash.ts 100.00% <100.00%> (ø)
...c/commandCreators/compound/dispenseInWasteChute.ts 100.00% <100.00%> (ø)
...rc/commandCreators/compound/dropTipInWasteChute.ts 97.36% <100.00%> (-0.26%) ⬇️
step-generation/src/utils/misc.ts 87.50% <0.00%> (+1.15%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jerader jerader merged commit 79395e9 into edge Mar 21, 2025
24 checks passed
@jerader jerader deleted the sg_move-to-add-area-py branch March 21, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants