Add custom Discord notification#686
Open
dirtboll wants to merge 2 commits into
Open
Conversation
This adds `discord_username` and `discord_avatar_url` environment variables for custom username and avatar URL. This also enables the ability to provide Discord message template in JSON format using `discord_message_template` environment variable. The provided template can contain format parameters that will be replaced to the scan result, such as `${file-path}`, `${malware-platform}`, `${malware-type}`, `${malware-family}`, `${malware-variant}`, `${malware-class-path}`, `${malware-source-path}`, and `${malware-line-number}`.
OpticFusion1
requested changes
Sep 9, 2023
| public static String format(String template, Map<String, Object> parameters) { | ||
| StringBuilder newTemplate = new StringBuilder(template); | ||
| List<Object> valueList = new ArrayList<>(); | ||
| Matcher matcher = Pattern.compile("[$][{]([\\w-_]+)}").matcher(template); |
Owner
There was a problem hiding this comment.
There is no reason to have to re-compile this on every method call, convert the Pattern to a CONSTANT.
Author
|
Sorry, I refactored it a bit. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to provide Discord notification template using JSON via
discord_message_templateenvironment variable. Example inside a bash script:Available format parameters:
If not using template, you can still customize username and avatar URL using
discord_usernameanddiscord_avatar_urlenvironment variable.