fix: WindowsCommand.is_in_path missing show_log parameter - #509
Open
HediKharouf0 wants to merge 1 commit into
Open
fix: WindowsCommand.is_in_path missing show_log parameter#509HediKharouf0 wants to merge 1 commit into
HediKharouf0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, launching GOAD crashes immediately with:
TypeError: WindowsCommand.is_in_path() takes 2 positional arguments but 3 were given
The Ludus provider calls is_in_path('ludus', False) but WindowsCommand in goad/command/windows.py overrides the parent method without the show_log parameter. Fixed by adding show_log=True as a default argument to match the base class signature.