Add CVE-2022-35947 REST API authentication bypass#13
Open
UncleJ4ck wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #12 into focused PRs per your feedback. This is the type-juggling auth bypass you flagged as interesting.
CVE-2022-35947 (GLPI 10.0.0-10.0.2).
/apirest.php/initSessionpasses theuser_tokenGET parameter toUser::getFromDBbyToken()without checking it is a string. Sending it as a PHP array (user_token[0]=>=&user_token[1]=) makes the ORM buildWHERE api_token >= '', which matches the first user with a non-empty API token and returns a session token unauthenticated. Fixed in 10.0.3 by anis_string()guard.Notes:
self.get, no hand-rolled requests.@authoris set toglpi: the GHSA (GHSA-7p3q-cffg-c8xh) credit is anonymized so there is no named researcher. Happy to change it if you know the reporter.--checkis read-only (attempts the bypass and reports the session token).Enable login with external token).