-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: New e-shop example #2434
Open
louismaximepiton
wants to merge
3
commits into
main
Choose a base branch
from
main-lmp-e-shop-rebased
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
925329e
to
094ee64
Compare
cc9a2eb
to
347758c
Compare
2fe8f46
to
77711bd
Compare
347758c
to
6a381eb
Compare
77711bd
to
555c600
Compare
5602e9b
to
ab8532f
Compare
7281b26
to
8d31874
Compare
ab8532f
to
369437c
Compare
First steps to have the card header End of first draft . . Some changes to respect a bit more the design Some design fixes . . fix(sonarCloud) fix(pa11yCi) better a11y first batch First release Adding the necessary files . fix(review) fix(review) Implementing new version of the counter Correct a Chrome bug fix(a11y review) fix(a11y review) + design changed . fix(a11y review) fix(a11y review) .
369437c
to
f1854db
Compare
The mode selector should be in the header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR supersedes #1839 which was approved in light mode only (a11y and design)
Related issues
Closes #1560
Description
Things to know before reviewing it
From
and orange price and 0px between this price and the optionnal one under..bg-danger
.border-supporting-*
shouldn't exist since its example related. They have been transformed into.border-success
and.border-info
.Things to tackle outside of this PR
ul
/p
, ... with multiple of 5 ?Saved information after the modification for the dark mode
1rst commit: 904c7a8
Commit with dark mode changes: db92da5
Motivation & Context
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge