Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore icons page #2889

Merged
merged 21 commits into from
Apr 2, 2025
Merged
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
722c034
restore icons page
hannahiss Mar 12, 2025
9a85cce
restore icons page, move icons color to icons page
hannahiss Mar 14, 2025
d934f91
adapt color doc, move sizes into extend/icons
hannahiss Mar 14, 2025
1c7058d
adapt icons doc, move sizes into extend/icons
hannahiss Mar 14, 2025
38cef99
adapt icons doc, move sizes into extend/icons
hannahiss Mar 14, 2025
7913788
link to guidelines
hannahiss Mar 14, 2025
920306a
fix links
hannahiss Mar 14, 2025
47478cb
Merge branch 'ouds/main' into ouds/main-2887-docs-add-extend-icons-page
hannahiss Mar 17, 2025
73c8217
fix some things after LM review, still work to do on accessibility icons
hannahiss Mar 18, 2025
7277642
Merge branch 'ouds/main' into ouds/main-2887-docs-add-extend-icons-page
hannahiss Mar 20, 2025
2c946c9
reviews changes
hannahiss Mar 20, 2025
08c255a
reviews changes
hannahiss Mar 20, 2025
6a87b71
review changes
hannahiss Mar 20, 2025
f6fdda5
same doc on icons for links and buttons
hannahiss Mar 21, 2025
c7c57ed
change asked by Vincent A.
hannahiss Mar 21, 2025
1061e9b
Merge branch 'refs/heads/ouds/main' into ouds/main-2887-docs-add-exte…
hannahiss Mar 24, 2025
c557586
Change CSS background image to mask image and adapt doc
hannahiss Mar 24, 2025
6f08d80
typos after reviews
hannahiss Apr 2, 2025
24be638
Merge branch 'ouds/main' into ouds/main-2887-docs-add-extend-icons-page
hannahiss Apr 2, 2025
edf3e3d
space between side to side buttons
hannahiss Apr 2, 2025
44045da
Add bg always white on img to ensure visibility in dark mode
hannahiss Apr 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions site/assets/scss/_component-examples.scss
Original file line number Diff line number Diff line change
@@ -502,13 +502,13 @@
// scss-docs-start icon-home
.icon-home::before {
display: inline-block;
width: 2rem;
height: 2rem;
width: 3rem;
height: 3rem;
vertical-align: bottom;
content: "";
background-color: var(--bs-color-content-default);
background-size: contain;
mask-image: url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 1000 1000'><path d='M553.478 147.416v.017a74.956 74.956 0 0 0-107.08.13v-.021L100 500h150v300a75 75 0 0 0 75 75h350a75 75 0 0 0 75-75V500h150ZM580 537.52V755H362.5a37.5 37.5 0 0 1-37.5-37.5V500h217.5a37.5 37.5 0 0 1 37.5 37.5v.02Z'/></svg>");
mask-image: escape-svg(url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 1000 1000'><path d='M553.478 147.416v.017a74.956 74.956 0 0 0-107.08.13v-.021L100 500h150v300a75 75 0 0 0 75 75h350a75 75 0 0 0 75-75V500h150ZM580 537.52V755H362.5a37.5 37.5 0 0 1-37.5-37.5V500h217.5a37.5 37.5 0 0 1 37.5 37.5v.02Z'/></svg>"));
}
// scss-docs-end icon-home

4 changes: 2 additions & 2 deletions site/content/docs/0.2/content/typography.md
Original file line number Diff line number Diff line change
@@ -76,7 +76,7 @@ All HTML headings, `<h1>` through `<h6>`, are available. Each class sets `font-s
<p class="h6">h6. OUDS Web heading</p>
{{< /example >}}

You can easily add an icon with your font reference using [our icon helper]({{< docsref "/helpers/icon" >}}).
You can easily add an icon with your font reference using [our icon size utilities]({{< docsref "/extend/icons#icons-size" >}}).

<!-- OUDS mod: No customizing heading -->

@@ -182,7 +182,7 @@ Body medium is set by default on `:root` children but we don't set the `max-widt

</details>

You can easily add an icon with your font reference using [our icon helper]({{< docsref "/helpers/icon" >}}).
You can easily add an icon with your font reference using [our icon size utilities]({{< docsref "/extend/icons#icons-size" >}}).

### Lead

729 changes: 727 additions & 2 deletions site/content/docs/0.2/extend/icons.md

Large diffs are not rendered by default.

490 changes: 0 additions & 490 deletions site/content/docs/0.2/helpers/icon.md

This file was deleted.

28 changes: 1 addition & 27 deletions site/content/docs/0.2/utilities/colors.md
Original file line number Diff line number Diff line change
@@ -97,33 +97,7 @@ In the following table we assume that the context is switching between light and

### On icons

The following color utilities are meant to be used only with icons and not with text.

{{< example >}}
<svg width="8em" height="8em" class="text-status-info" aria-hidden="true">
<use xlink:href="/docs/{{< param docs_version >}}/assets/img/ouds-web-sprite.svg#info"/>
</svg>
<svg width="8em" height="8em" class="text-status-positive" aria-hidden="true">
<use xlink:href="/docs/{{< param docs_version >}}/assets/img/ouds-web-sprite.svg#tick-confirmation"/>
</svg>
<svg width="8em" height="8em" class="text-status-warning" aria-hidden="true">
<use xlink:href="/docs/{{< param docs_version >}}/assets/img/ouds-web-sprite.svg#important"/>
</svg>
<svg width="8em" height="8em" class="text-status-negative" aria-hidden="true">
<use xlink:href="/docs/{{< param docs_version >}}/assets/img/ouds-web-sprite.svg#error-severe"/>
</svg>
{{< /example >}}

Here are [the normal contexts of use of these text color utilities](https://unified-design-system.orange.com/472794e18/p/217ac6-colour/t/9b95834c2e).

{{< bs-table >}}
| Color utility | Context of use |
| --- | --- |
| `.text-status-info` | Use to communicate a feedback. It's more important than a neutral color. |
| `.text-status-positive` | Use to communicate a positive action, a confirmation or a positive feedback. |
| `.text-status-warning` | Use to display an information that requires more attention, or an action from the user. |
| `.text-status-negative` | Use to communicate something negative. It can be a destructive action, an error state, or a negative feedback. |
{{< /bs-table >}}
See [icons documentation]({{< docsref "/extend/icons/#icons-color" >}}) to learn how to use color utilities on icons.

<!-- ## Opacity -->

2 changes: 1 addition & 1 deletion site/content/docs/0.2/utilities/text.md
Original file line number Diff line number Diff line change
@@ -143,7 +143,7 @@ These classes change the `font-size` but also the `line-height`, the `letter-spa

Customize your available `font-size`s by modifying the `$ouds-font-sizes` Sass map.

You can easily add an icon with your font reference using [our icon helper]({{< docsref "/helpers/icon" >}}).
You can easily add an icon with your font reference using [our icon size utilities]({{< docsref "/extend/icons#icons-size" >}}).

{{< bootstrap-compatibility >}}

1 change: 0 additions & 1 deletion site/data/sidebar.yml
Original file line number Diff line number Diff line change
@@ -215,7 +215,6 @@
pages:
- title: Approach
- title: Icons
draft: true

- title: About
icon: globe2
Binary file added site/static/docs/0.2/assets/img/heart-recommend.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions site/static/docs/0.2/assets/img/ouds-web-sprite.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.