Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Add Switch component #2924

Open
wants to merge 6 commits into
base: ouds/main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 24, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2843

Description

Add Switch component using appearance: none so we have pseudo-elements.

⚠️ Questions

  • See with a11y if we should take into account the prefers reduced motion.
  • Probably need to use partials to only need to change the text once.
  • Where should the CSS code be ?

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added ⚛️ component 📖 documentation Improvements or additions to documentation labels Mar 24, 2025
@louismaximepiton louismaximepiton added this to the OUDS milestone Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 56e92af
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/67ee8db8adf13d0008aa05c6
😎 Deploy Preview https://deploy-preview-2924--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton linked an issue Mar 24, 2025 that may be closed by this pull request
@louismaximepiton louismaximepiton self-assigned this Mar 27, 2025
Base automatically changed from ouds/main-lmp-checkbox-components to ouds/main March 31, 2025 13:39
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-switch-component branch from ca719d5 to a26430b Compare April 1, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛️ component 📖 documentation Improvements or additions to documentation
Projects
Status: Need Dev Review
Development

Successfully merging this pull request may close these issues.

[OUDS] Create component - Switch
2 participants