Skip to content

Comments

feat(component): Add Switch component#2924

Merged
louismaximepiton merged 9 commits intoouds/mainfrom
ouds/main-lmp-switch-component
Apr 7, 2025
Merged

feat(component): Add Switch component#2924
louismaximepiton merged 9 commits intoouds/mainfrom
ouds/main-lmp-switch-component

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Mar 24, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

Closes #2843

Description

Add Switch component using appearance: none so we have pseudo-elements.

⚠️ Questions

  • See with a11y if we should take into account the prefers reduced motion.
  • Probably need to use partials to only need to change the text once.
  • Where should the CSS code be ?

Motivation & Context

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added ⚛️ component 📖 documentation Improvements or additions to documentation labels Mar 24, 2025
@louismaximepiton louismaximepiton added this to the OUDS milestone Mar 24, 2025
@netlify
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c0caa65
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/67f39194ca41a300085a3aa9
😎 Deploy Preview https://deploy-preview-2924--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton linked an issue Mar 24, 2025 that may be closed by this pull request
@louismaximepiton louismaximepiton self-assigned this Mar 27, 2025
Base automatically changed from ouds/main-lmp-checkbox-components to ouds/main March 31, 2025 13:39
@louismaximepiton louismaximepiton moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 1, 2025
@louismaximepiton louismaximepiton force-pushed the ouds/main-lmp-switch-component branch from ca719d5 to a26430b Compare April 1, 2025 12:00
Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, only two minor things and a comment

Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 7, 2025
@louismaximepiton louismaximepiton merged commit df27446 into ouds/main Apr 7, 2025
13 checks passed
@louismaximepiton louismaximepiton deleted the ouds/main-lmp-switch-component branch April 7, 2025 08:57
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚛️ component 📖 documentation Improvements or additions to documentation

Projects

Development

Successfully merging this pull request may close these issues.

[OUDS] Create component - Switch

2 participants