[OUDS] Divider component #2932
Merged
[OUDS] Divider component #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-project-automation
bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
louismaximepiton
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Dividers component to provide horizontal and vertical rule helpers and updates the corresponding documentation and migration guides. Key changes include:
- Adding a new "Dividers" entry in the sidebar.
- Updating migration documentation to reference the new Dividers helper.
- Creating a new Dividers documentation file and updating horizontal rule examples in reboot.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| site/data/sidebar.yml | Added a new "Dividers" entry to the sidebar navigation. |
| site/content/docs/0.3/migration.md | Updated migration documentation with Dividers helper details. |
| site/content/docs/0.3/migration-from-boosted.md | Updated migration-from-boosted documentation for dividers. |
| site/content/docs/0.3/helpers/dividers.md | Added new documentation for Dividers helpers. |
| site/content/docs/0.3/content/reboot.md | Revised horizontal rule examples and descriptions. |
Files not reviewed (2)
- scss/_variables.scss: Language not supported
- scss/helpers/_vr.scss: Language not supported
louismaximepiton
requested changes
Apr 1, 2025
There was a problem hiding this comment.
I'mwondering if we should add vertical-align somehow to make sure people don't struggle too much in block context. Tried it using inline-blocks and the rendering was weird.
louismaximepiton
moved this from Need Dev Review
to Dev Review In Progress
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
nilloq
force-pushed
the
ouds/main-2826-sco-divider-component
branch
from
245ed97 to
061c143
Compare
nilloq
force-pushed
the
ouds/main-2826-sco-divider-component
branch
from
061c143 to
be13e06
Compare
|
Taken into account your global comment:
|
github-project-automation
bot
moved this from Dev Review In Progress
to Done
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #2826
Description
Default
<hr>styled in rebootNew divider helpers for horizontal and vertical rules
Motivation & Context
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)