Skip to content

[OUDS] Design review fix: invalid example with 2 radio buttons and was-validated #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MaxLardenois
Copy link
Collaborator

@MaxLardenois MaxLardenois commented Apr 4, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

closes #2946

Description

Add a second radio button in the invalid state example, require and enclose both in a .was-validated form to show the natural Invalid state via :invalid pseudo-class.

Motivation & Context

Design review

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is well displayed in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a1cd30c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/67efef177229500008f7186f
😎 Deploy Preview https://deploy-preview-2948--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MaxLardenois MaxLardenois marked this pull request as ready for review April 4, 2025 08:49
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 4, 2025
@MaxLardenois
Copy link
Collaborator Author

@B3nz01d is this ok for you? It closes issue #2946

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the .was-validated and .is-invalid are 2 correct ways to display the error in the doc, I'm fine using the .was-validated in here but we should maybe update the paragraph just before.

@MaxLardenois MaxLardenois force-pushed the ouds/main-2946-in-the-radio-button-documentation-the-invalid-state-should-display-the-example-with-2-radio-button-items branch from ab8cc6b to c054aae Compare April 4, 2025 14:14
@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 7, 2025
@MaxLardenois MaxLardenois merged commit 798edc6 into ouds/main Apr 7, 2025
13 checks passed
@MaxLardenois MaxLardenois deleted the ouds/main-2946-in-the-radio-button-documentation-the-invalid-state-should-display-the-example-with-2-radio-button-items branch April 7, 2025 08:21
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

In the Radio button documentation the Invalid state should display the example with 2 radio button items
2 participants