Skip to content

[OUDS] Add readonly on control item components #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: ouds/main
Choose a base branch
from

Conversation

MaxLardenois
Copy link
Collaborator

@MaxLardenois MaxLardenois commented Apr 4, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

closes #2950

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 70bbbd8
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6801069f42c0e40008de2406
😎 Deploy Preview https://deploy-preview-2951--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MaxLardenois MaxLardenois force-pushed the ouds/main-2950-ouds-add-readonly-state-on-checkboxradioswitch-components branch from 1a8336e to 589eeb1 Compare April 9, 2025 13:57
Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must add :

Read only

To create a read only Checkbox the input should be replaced by a span element with role="checkbox", aria-readonly and aria-disabled attributes. The Checkbox will be accessible to keyboard navigation and assistive technologies thanks to aria-labelledby and tabindex but other interactions will be prevented.

@MaxLardenois MaxLardenois marked this pull request as ready for review April 17, 2025 10:45
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Need Dev Review
Development

Successfully merging this pull request may close these issues.

[OUDS] add readonly state on Checkbox/Radio/Switch components
2 participants