Skip to content

feat(lib): Remove useless mixin rfs and font-size + remove vendor#3504

Open
louismaximepiton wants to merge 3 commits intoouds/mainfrom
ouds/main-lmp-remove-rfs
Open

feat(lib): Remove useless mixin rfs and font-size + remove vendor#3504
louismaximepiton wants to merge 3 commits intoouds/mainfrom
ouds/main-lmp-remove-rfs

Conversation

@louismaximepiton
Copy link
Copy Markdown
Member

@louismaximepiton louismaximepiton commented Apr 9, 2026

Types of change

  • Non-breaking change
  • Breaking change (fix or feature that would change existing functionality and usage)

Related issues

Following twbs/bootstrap#41938.

Context & Motivation

Reduce our bundle size on CSS and remove dead code.

Description

Removes the rfs mixins and functions, as well as the font-size mixin.

Checklists

  • I have read the contributing guidelines
  • My change follows the developer guide
  • My change pass all tests
  • My change is compatible with a responsive display
  • I have added tests (Javascript unit test or visual) to cover my changes
  • My change introduces changes to the documentation that I have updated accordingly
    • Title and DOM structure is correct
    • Links have been updated (title changes impact links)
    • CSS for the documentation
  • I have checked all states and combinations of the component with my change
  • I have checked all the impacts for the other components and core behavior (grid, reboot, utilities)

Checklist (for Core Team only)

  • The changes need to be in the migration guide
  • The changes are well displayed in Storybook (be careful if example order has changed for DSM)
  • The changes are compatible with RTL
  • Manually test browser compatibility with BrowserStack (Chrome 120, Firefox 121, Edge 120, Safari 15.6, iOS Safari, Chrome & Firefox on Android)

Progression (for Core Team only)

Live previews

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 38becd8
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/69e0acf4e84c7600087c41a4
😎 Deploy Preview https://deploy-preview-3504--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@louismaximepiton louismaximepiton marked this pull request as ready for review April 9, 2026 13:43
Copilot AI review requested due to automatic review settings April 9, 2026 13:43
@boosted-bot boosted-bot moved this from In Progress / Draft to Need Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Apr 9, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the RFS vendor implementation and related Sass mixins (rfs, font-size) across the SCSS codebase to reduce CSS bundle size, and updates the site/config/docs accordingly.

Changes:

  • Remove the RFS vendor file and all remaining @include rfs(...) / @include font-size(...) usages, replacing them with direct font-size: / CSS variable assignments.
  • Simplify utilities generation by dropping the RFS-specific branch and its tests.
  • Remove rfs_version from site config validation and from brand config files; update docs/migration notes to reflect the breaking change.

Reviewed changes

Copilot reviewed 39 out of 40 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
site/src/scss/_component-examples.scss Replace @include font-size(inherit) with font-size: inherit.
site/src/libs/validation.ts Remove zPrefixedVersionSemver validator (no longer needed).
site/src/libs/config.ts Drop rfs_version from config schema/imports.
site/src/content/docs/utilities/api.mdx Remove the (commented) rfs utility option row.
site/src/content/docs/getting-started/migration.mdx Add migration notes about RFS/vendor and font-size() removal.
site/src/content/docs/getting-started/migration-from-boosted.mdx Add similar migration notes for Boosted migrations.
site/src/content/docs/foundation/options.mdx Remove $enable-rfs mention from options table.
scss/vendor/_rfs.scss Delete the embedded RFS implementation.
scss/utilities/_api.scss Remove the RFS rescaling media-query generation block.
scss/tests/mixins/_utilities.test.scss Remove RFS-related generate-utility tests.
scss/mixins/_utilities.scss Remove $is-rfs-media-query arg + RFS value selection logic.
scss/mixins/_pagination.scss Replace @include rfs(..., --var) with direct CSS var assignment.
scss/mixins/_forms.scss Replace @include font-size(...) with font-size:.
scss/mixins/_buttons.scss Replace @include rfs(..., --var) with direct CSS var assignment.
scss/forms/_labels.scss Replace @include font-size(...) with font-size:.
scss/forms/_input-group.scss Replace @include font-size(...) with font-size:.
scss/forms/_form-text.scss Update comment to reflect direct font-size replacement context.
scss/forms/_form-control.scss Replace @include font-size(...) with font-size:.
scss/_variables.scss Remove $enable-rfs variable.
scss/_type.scss Update comments to reflect direct font-size replacement.
scss/_tooltip.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_toasts.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_root.scss Replace @include rfs(..., --body-font-size) with direct CSS var assignment.
scss/_reboot.scss Replace @include font-size(...) with font-size: in reboot rules.
scss/_progress.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_popover.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_pagination.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_navbar.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_nav.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_mixins.scss Stop importing vendor RFS.
scss/_images.scss Replace @include font-size(...) with font-size:.
scss/_dropdown.scss Replace RFS/css mixin usage with direct var assignment + font-size:.
scss/_buttons.scss Update comment reflecting removal of --btn-font-size handling.
scss/_accordion.scss Replace @include font-size(...) with font-size:.
packages/sosh/scss/ouds-web-grid.scss Remove @import "@ouds/web-common/scss/vendor/rfs".
packages/sosh/config.yml Remove rfs_version entry.
packages/orange/scss/ouds-web-grid.scss Remove @import "@ouds/web-common/scss/vendor/rfs".
packages/orange/config.yml Remove rfs_version entry.
packages/orange-compact/scss/ouds-web-grid.scss Remove @import "@ouds/web-common/scss/vendor/rfs".
packages/orange-compact/config.yml Remove rfs_version entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread site/src/content/docs/getting-started/migration.mdx Outdated
Comment thread site/src/content/docs/getting-started/migration.mdx
Comment thread site/src/content/docs/getting-started/migration-from-boosted.mdx Outdated
Comment thread site/src/content/docs/getting-started/migration-from-boosted.mdx Outdated
Comment thread site/src/content/docs/getting-started/migration.mdx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Need Dev Review

Development

Successfully merging this pull request may close these issues.

3 participants