Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add CSS, dark/light mode and popover theme use cases #542

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

docs: add CSS, dark/light mode and popover theme use cases #542

wants to merge 8 commits into from

Conversation

jacques-lebourgeois
Copy link
Member

Related issues

Description

Provides a new use case page on ODS Charts options to choose the theme provider.

Motivation & Context

Options may be complex between options for:

  • CSS theme ,
  • popover renderer
  • dark/light mode

Types of change

  • New feature

Test checklist

Please check that the following tests projects are still working:

  • docs/examples
  • test/angular-ngx-echarts
  • test\angular-ng-boosted
  • test/angular-echarts
  • test/html
  • test/react
  • test/vue
  • test/examples/bar-line-chart
  • test/examples/single-line-chart
  • test/examples/timeseries-chart

@netlify Netlify
Copy link

netlify bot commented Mar 31, 2025 •
edited
Loading

✅ Deploy Preview for ods-charts ready!

Name Link
🔨 Latest commit f92ac65
🔍 Latest deploy log https://app.netlify.com/sites/ods-charts/deploys/67ed541f2b50560008111504
😎 Deploy Preview https://deploy-preview-542--ods-charts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jacques-lebourgeois jacques-lebourgeois added documentation Improvements or additions to documentation library labels Mar 31, 2025
louismaximepiton
louismaximepiton requested changes Apr 2, 2025
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may run npm run prettier:format to fix CI and rebase the branch.

The branch looks good as is.

jacques-lebourgeois and others added 7 commits April 2, 2025 16:54
@jacques-lebourgeois @louismaximepiton
Update docs/use_cases/theme.html
16913ed 
Co-authored-by: Louis-Maxime Piton <[email protected]>
@jacques-lebourgeois @louismaximepiton
Update docs/use_cases/theme.html
6dc3795 
Co-authored-by: Louis-Maxime Piton <[email protected]>
@jacques-lebourgeois @louismaximepiton
Update docs/use_cases/theme.html
62d4f7c 
Co-authored-by: Louis-Maxime Piton <[email protected]>
@jacques-lebourgeois @louismaximepiton
Update docs/use_cases/theme.html
2f88adb 
Co-authored-by: Louis-Maxime Piton <[email protected]>
@jacques-lebourgeois @louismaximepiton
Update docs/use_cases/theme.html
71a663f 
Co-authored-by: Louis-Maxime Piton <[email protected]>
@jacques-lebourgeois @louismaximepiton
Update docs/use_cases/theme.html
18ccdef 
Co-authored-by: Louis-Maxime Piton <[email protected]>
@louismaximepiton
fix(ci)
f92ac65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacques-lebourgeois @louismaximepiton