Skip to content

48 create component radio button #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

AhmedAmineZr
Copy link
Member

@AhmedAmineZr AhmedAmineZr commented May 9, 2025

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#48

Description

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@AhmedAmineZr AhmedAmineZr linked an issue May 9, 2025 that may be closed by this pull request
@AhmedAmineZr AhmedAmineZr self-assigned this May 9, 2025
@AhmedAmineZr AhmedAmineZr requested a review from Tayebsed93 May 9, 2025 15:04
@AhmedAmineZr AhmedAmineZr force-pushed the 48-create-component---radio-button branch 4 times, most recently from c32fd35 to db7bc57 Compare May 14, 2025 08:38
@@ -0,0 +1,140 @@
/*
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je pense que ce serait plus pertinent d'avoir le nom du dossier comme ceci : radio_button au lieu de radio

ouds_core/lib/components/radio_button/ouds_radio_button.dart

import 'package:ouds_core/components/utilities/app_assets.dart';
import 'package:ouds_core/ouds_theme.dart';

class OudsRadioButton<T> extends StatefulWidget {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux petites améliorations sur la documentation :

  1. La mettre juste au dessus de la classe donc à la ligne 35
  2. Je te fournis la documentation juste en dessus :
///
/// [OUDS Radio Button Design Guidelines](https://unified-design-system.orange.com/472794e18/p/90c467-radio-button)
///
/// An OUDS-compliant radio button widget.
///
/// This widget displays a radio button that is part of a group. It determines its selected state
/// by comparing its own [value] with the current [groupValue]. It also supports an error state
/// and notifies changes through [onChanged].
///
/// @param [value] The value represented by this radio button. Used to determine selection.
/// @param [groupValue] The currently selected value in the radio button group.  
/// This radio button is considered selected if [value] == [groupValue].
/// @param [onChanged] Callback triggered when the user selects this radio button.  
/// If `null`, the radio button is disabled and non-interactive.
/// @param [isError] Indicates whether the radio button is in an error state.
///
/// @sample com.orange.ouds.core.component.samples.OudsRadioButtonSample

@Tayebsed93
Copy link
Collaborator

@AhmedAmineZr In the pressed state, the outlined option should be applied to the item, as seen in the iOS or Android versions.

@AhmedAmineZr
Copy link
Member Author

AhmedAmineZr commented May 14, 2025

I made the some as iOS they did and the behavior of Figma:

flutter_version

iOS_version

@AhmedAmineZr AhmedAmineZr reopened this May 14, 2025
@AhmedAmineZr AhmedAmineZr force-pushed the 48-create-component---radio-button branch from a1c8058 to 21d6bac Compare May 14, 2025 16:01
@Tayebsed93 Tayebsed93 force-pushed the 48-create-component---radio-button branch from d62dea4 to 4e175b8 Compare May 15, 2025 13:28
@AhmedAmineZr
Copy link
Member Author

AhmedAmineZr commented May 15, 2025

📣 New Firebase App Distribution ALPHA upload available 🚀 (Android)

Please, get the new build from App Tester app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: DesignToolbox (alpha) (186)
Version: 0.3.0
Build type: ALPHA
Build details (GitHub): 48
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

@AhmedAmineZr
Copy link
Member Author

AhmedAmineZr commented May 15, 2025

📣 New TestFlight ALPHA upload available 🚀 (iOS)

Please, get the new build from TestFlight app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: Design Toolbox Flutter (186)
Version: 0.3.0
Build type: ALPHA
Build details (GitHub): 48
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create component - Radio Button
5 participants