Skip to content

57-create-component---divider #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

57-create-component---divider #183

wants to merge 17 commits into from

Conversation

nouha06
Copy link
Member

@nouha06 nouha06 commented May 14, 2025 •
edited
Loading

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#57

Description

add custom dropdownmenu
add divider component

Motivation & Context

Types of change

  • Bug fix (non-breaking which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices

Design

  • My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • Manually test (dark mode, RTL, landscape display, tablet)
  • Documentation has been updated if relevant
  • Design review
  • A11y review
  • Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
  • changelog.md has been updated respecting keep a changelog rules and referencing the issue

@nouha06 nouha06 requested a review from Tayebsed93 May 14, 2025 15:24
@nouha06 nouha06 linked an issue May 14, 2025 that may be closed by this pull request
Create component - Divider #57
Open
@nouha06 nouha06 self-assigned this May 14, 2025
@Tayebsed93
Copy link
Collaborator

@nouha06 The test builds aren't working — could you check what's going on?

Screen :

Capture d’écran 2025-05-14 à 20 39 06

@Tayebsed93 Tayebsed93 force-pushed the 57-create-component---divider branch from 1738d4d to 9640d00 Compare May 15, 2025 12:54
@nouha06
Copy link
Member Author

nouha06 commented May 15, 2025

📣 New Firebase App Distribution ALPHA upload available 🚀 (Android)

Please, get the new build from App Tester app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: DesignToolbox (alpha) (184)
Version: 0.3.0
Build type: ALPHA
Build details (GitHub): 57
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

@nouha06
Copy link
Member Author

nouha06 commented May 15, 2025

📣 New TestFlight ALPHA upload available 🚀 (iOS)

Please, get the new build from TestFlight app, or contact the project maintainers (@Tayebsed93) to get access.

Display name: Design Toolbox Flutter (184)
Version: 0.3.0
Build type: ALPHA
Build details (GitHub): 57
cc @B3nz01d (product owner)
cc @Tayebsed93 @AhmedAmineZr @nouha06 (dev team)
cc @MaximeTonnerre @mccart77 @iassab @TonyAntonyHello (design team)

@nouha06 nouha06 added the ⭐ v1.0 Tickets needed for mobile v1.0 release label May 15, 2025
@B3nz01d
Copy link
Collaborator

B3nz01d commented May 20, 2025

@ tayeb: The color name for the default color is not "Default color" but "Default"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tayebsed93 Tayebsed93 Tayebsed93 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@B3nz01d B3nz01d

@pya35 pya35

@MaximeTonnerre MaximeTonnerre

@nouha06 nouha06

Labels
⚛️ component 📱 demo app 🧰 library ⭐ v1.0 Tickets needed for mobile v1.0 release ⌛ waiting for validations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create component - Divider
5 participants
@nouha06 @Tayebsed93 @B3nz01d @pya35 @MaximeTonnerre