Skip to content

Conversation

@justinbaskaran
Copy link

So i added a refresh option, so that if users have messages that are out of sync, or not getting messages, they can use this option to force a reload of the web app.....

@OrangeDrangon
Copy link
Owner

Why was this closed I am not necessarily opposed to this?

@justinbaskaran
Copy link
Author

justinbaskaran commented Oct 9, 2022

Hey Kyle, I closed it because if you go to View -> Reload it does something similar (this feature would have been a forced reload of the web app on electron), so I guess we could keep it open? what do you think? I think the issue is reload vs forceReload....so once basically forces the electron app to refresh... we could keep it....for usablitiy, we should probably keep one of them, its up to you, though

@justinbaskaran justinbaskaran reopened this Oct 9, 2022
@OrangeDrangon
Copy link
Owner

Sorry for being slow to get back to you. If you find the already existing reload working then yeah we probably do not need this. Let me know if the preexisting button is solving the issues you are running into.

Comment on lines +40 to +43
{
label: "Refresh",
role: "forceReload",
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably not be part of the setting menu. If we go with this action type i would prefer to see it in the window menu. It will also need to match the key binds of the already existing refresh, Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants