Skip to content

Fix deprecated mc call, add more logging on CI failure #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 1, 2025
Merged

Fix deprecated mc call, add more logging on CI failure #555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6de570
Tear down existing containers in CI & wait for buckets
AetherUnbound May 26, 2025
421a225
Print logs on failure
AetherUnbound May 28, 2025
091cbe1
Actually print logs
AetherUnbound May 28, 2025
81e6961
Post all available logs
AetherUnbound May 28, 2025
5ad80df
Typo
AetherUnbound May 28, 2025
8b48a10
Add `FOLLOW_LOGS` variable to print everything via `just logs`
AetherUnbound May 28, 2025
a7ded6b
Use updated `mc` command
AetherUnbound May 28, 2025
6f6e035
Remove debug lines
AetherUnbound Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ jobs:
with:
name: playwright-traces
path: build/test-results/
- if: ${{ failure() }}
name: Print logs
run: |
FOLLOW_LOGS='' just logs
2 changes: 1 addition & 1 deletion docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ services:
entrypoint: >
/bin/sh -c "
sleep 5;
/usr/bin/mc config host add myminio http://minio:9000 minio ${MINIO_ROOT_PASSWORD};
/usr/bin/mc alias set myminio http://minio:9000 minio ${MINIO_ROOT_PASSWORD};
/usr/bin/mc mb myminio/${S3_BUCKET_NAME};
/usr/bin/mc anonymous set public myminio/${S3_BUCKET_NAME};
exit 0;
Expand Down
3 changes: 2 additions & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ COMPOSE_FILE := "--file=docker-compose.yml" + (
DC := "docker compose " + COMPOSE_FILE
RUN := DC + " run --rm"
RUN_WEB := RUN + " web"
FOLLOW_LOGS := env("FOLLOW_LOGS", "-f")
set dotenv-load := false
# Force just to hand down positional arguments so quoted arguments with spaces are
# handled appropriately
Expand Down Expand Up @@ -42,7 +43,7 @@ down *args:

# Attach logs to all (or the specified) services
logs *args:
{{ DC }} logs -f {{ args }}
{{ DC }} logs {{ FOLLOW_LOGS }} {{ args }}

# Pull all docker images
pull:
Expand Down
Loading