OCC-221: Fix unnecessary payment intent creation and fix new obsoletes#730
Open
sarahelsaig wants to merge 42 commits intomainfrom
Open
OCC-221: Fix unnecessary payment intent creation and fix new obsoletes#730sarahelsaig wants to merge 42 commits intomainfrom
sarahelsaig wants to merge 42 commits intomainfrom
Conversation
…eckout. This is caused by XHR calls to ~/checkout/price in the background.
sarahelsaig
changed the title
Contributor
|
Just a quick comment. I think I needed to fix the fact that shopping cart cookies are not tenant aware. Maybe you will want to take a look if not already fixed. |
Contributor
Author
This PR didn't touch the shopping cart cookies so it's probably not fixed yet. Could you please open a new issue and elaborate on what kind of tenant awareness was necessary? If you can include a snippet or description of your fix that'd be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCC-221
They are created in the background while you edit the addresses during checkout. It's because calls ~/checkout/price in case the prices need to be updated, which implicitly requests the payment provider data. The solution is to check if the price hasn't changed and the status is
requires_payment_method(this is the status before you click on the payment provider button) then just use the stored payment intent instead.Fixes #407