Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and enhances the
ShapeResultclass inShapeResult.csto improve performance, memory efficiency, and code clarity. The main changes include optimizing how display type locations are stored, improving the async predicate evaluation logic, and reorganizing method definitions for better structure.Performance and Memory Optimizations:
_firstDisplayType,_firstLocation,_secondDisplayType,_secondLocation) before falling back to a dictionary for additional pairs. This reduces memory allocations for common cases with only one or two display types. [1] [2]API and Usability Improvements:
Prefix,Location,Displaying,Processing,Name,Differentiator,OnGroup,Cache,RenderWhen) to appear before the core implementation logic, improving code organization and discoverability. [1] [2]Async Predicate Handling:
RenderWhenpredicate so that if the predicate completes synchronously, the result is used immediately, otherwise it is awaited asynchronously. This avoids unnecessary async state machine overhead when possible.