test: make ControlChart toString tests JS-compatible#114
Merged
Conversation
On Kotlin/JS `Double.toString()` drops the trailing `.0` for whole-number doubles (`(0.0).toString() == "0"`, `(10.0).toString() == "10"`), unlike JVM. `DoubleArray.contentToString()` inherits this, so literal assertions on `"0.0"` / `"10.0"` substrings failed on jsNodeTest and jsBrowserTest. Replace whole-number seed values in the two affected fixtures with non-zero-fraction values that format identically on both platforms, and add a short note so the trap does not get re-set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Kotlin/JS
Double.toString()drops the trailing.0for whole-number doubles(
(0.0).toString() == "0",(10.0).toString() == "10"), unlike JVM.DoubleArray.contentToString()inherits this, so the twoControlChartTestcasesthat asserted literal
"0.0"/"10.0"substrings failed onjsNodeTestandjsBrowserTest. Replace whole-number seed values in the affected fixtures withnon-zero-fraction values that format identically on both platforms, and add a
short note so the trap does not get re-set. Production
toString()is unchanged.Testing
./gradlew :kstats-core:jvmTest :kstats-core:jsNodeTest :kstats-core:jsBrowserTest(full
ControlChartTestgreen on all three targets)Checklist