Sync VideoStudio contracts and prepare 2026.9.10 - #36
Merged
Conversation
Adapt the frozen Orkas 59a8824 source to portable core/tools contracts and thin CLI/MCP entrypoints. Add measured delivery verification, narration receipts, canonical timing and current-user amendment support; preserve target providers and pinned HyperFrames. Validation: all six required commands passed; full suite with real HyperFrames E2E: 290 passed, 1 skipped. Policy check passed after registering all new owning tests. Prompt audit: - **Routing rule, resident in video-router/orchestration:** distinguish modifications of an existing video's timeline from new multiaxis production; a fully specified deterministic edit needs no redundant direction plan. This is required at task entry, before optional line skills load. - **Authority rule, resident in gate-control:** consume current explicit user instructions, never infer approval from turns, retain pending artifact identity and bound exhausted QA. Native quote/turn validation is dropped because OVS has no host conversation store. Line roots point to this single authority. - **Plan contract, orchestration plus conditional compose authoring:** replace mandatory script/shotlist duplication with one manifest. Retain legacy source-alignment checks for existing artifacts. The root owns the handoff; schema details load only for authoring. - **Visual checklist, composition-design-review:** drop numeric pass-score/submission gates; retain concrete frame evidence, one batched localized repair and user-approved intent. Inspect the complete contact index plus full-size cover/risky frames, with no duplicate static review after unchanged rendering. - **Timing contract, scaffold and compose guidance:** S/D helpers derive animation positions from canonical windows; preserve explicit silence and readable opening. HyperFrames visibility remains the sole runtime owner. Pure identity helpers do not grant authorization by themselves. - **Narration execution guidance, conditional audio/transcript references:** exact executable BYO request, immutable line windows and matching receipt reuse. Preserve existing/lip-synced speech and single audio ownership. Drop managed-voice and native-ledger APIs. Language is receipt metadata for the compatible speech endpoint, not an invented provider parameter. - **Delivery contract, assemble/edit guidance and thin entrypoints:** require real final-file verification for plan-backed delivery. Keep caption and audio evidence limitations visible; do not infer actual delivery from planned durations. Failed or unknown billable outcomes never authorize a new charge. - **Version/PR workflow, AGENTS and README:** retain one calendar version and requester-confirmed PR creation. Resident AGENTS placement is necessary before repository mutation; release details live in the changelog. This rule does not introduce production-video approval requirements. - **Conditional loading:** detailed manifest/art-direction/narration/transcript and AUTO-child instructions are referenced from the owning root and shipped by the existing references glob. Installed effective-instruction tests read these references and enforce the public command boundary.
Upgrade the raw-render smoke case into a nine-second, three-scene production driven through the built OVS CLI. Prepare/reconcile, snapshot, draft, burn captions and verify the delivered file; assert full decoding, scene order, visible motion, audio across all scenes, actual caption pixels and wrong-duration rejection. Preserve optional review artifacts outside the checkout. Wire this case into pnpm verify, already used by CI. It uses local original graphics and instrumental audio without paid services. Video duration is checked independently from AAC tail padding, within the existing delivery tolerance. Validation: the production case and pnpm verify passed before this commit; all six source sync verification commands passed on the same candidate, with executed-case evidence and content-hash stability. Prompt audit: - Keep the pre-commit/PR production requirement in AGENTS as a resident repository workflow rule: a contributor must know it before invoking Git, where an on-demand production skill may never be loaded. The executable requirement belongs to pnpm verify and the sync checker; AGENTS only defines when to run it and inspect evidence. - Keep command details and retained-artifact usage in the on-demand README; no duplicate production approval flow or Agent/Skill instruction is introduced. The user explicitly requested actual test-video production before submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Sync the reviewed VideoStudio contracts into the public core, tools, CLI/MCP and skills. Final-file promise checks now measure the delivered video; canonical scene timing, narration receipts, edit coverage and current-user amendments have matching deterministic coverage. Preserve existing BYO provider integrations and HyperFrames 0.7.60.
Prepare the independent calendar version
2026.9.10consistently across workspace packages and MCP. Document the synchronization and version policy.Make real video production mandatory in
pnpm verifybefore commits and PRs. The public CLI E2E produces a nine-second, three-scene 1080p MP4 with motion, audio and burned captions, verifies the complete decode, scene order, motion, caption pixels and audio, and rejects an incorrect delivery-duration promise.Validation
pnpm verifypassed on the final candidate: build, typecheck, tests, benchmark, video capability and real HyperFrames E2E.Provider tests use local fixtures; no paid-provider or model-quality evaluation is claimed. Requester approval to create and merge this PR was received after local verification.