Wip windows by Osyotr · Pull Request #1 · Osyotr/organicmaps

Osyotr · 2024-04-09T22:39:58Z

No description provided.

vaanwd · 2024-11-17T17:16:36Z

Hello!
Do you have some instrunctions of how to build Organic Maps on Windows?
Thank`s!

Osyotr · 2024-11-17T19:43:34Z

The build steps are there: https://github.com/Osyotr/organicmaps/blob/wip-windows/.github/workflows/windows-check.yaml
The important step is to skip some submodules.

PS: windows builds are not usable at this moment due to organicmaps#7838

vaanwd · 2024-11-19T09:17:40Z

The build steps are there: https://github.com/Osyotr/organicmaps/blob/wip-windows/.github/workflows/windows-check.yaml The important step is to skip some submodules.

PS: windows builds are not usable at this moment due to organicmaps#7838

Yes, i have the same problem(Black screen) in Arch Linux with QT 6.8.
There is a posibility to downgrade QT in vcpkg?

Osyotr · 2024-11-19T09:53:34Z

Yes but I think the OpenGL issue is deeper because with Qt 6.6 it will crash 9/10 times.
https://learn.microsoft.com/en-us/vcpkg/consume/lock-package-versions?tabs=inspect-powershell#5---force-a-specific-version

Signed-off-by: Alexander Borsuk <me@alex.bio>

Co-authored-by: Alexander Gabilondo <alexgabi@openmailbox.org> Co-authored-by: Hosted Weblate <hosted@weblate.org> Co-authored-by: Jaŭhien <j.kisliakou@gmail.com> Co-authored-by: Jim Kats <jim-kats@hotmail.com> Co-authored-by: Sketch6580 <sketch6580@users.noreply.hosted.weblate.org> Co-authored-by: Максим Горпиніч <gorpinicmaksim0@gmail.com> Signed-off-by: Alexander Gabilondo <alexgabi@openmailbox.org> Signed-off-by: Jaŭhien <j.kisliakou@gmail.com> Signed-off-by: Jim Kats <jim-kats@hotmail.com> Signed-off-by: Sketch6580 <sketch6580@users.noreply.hosted.weblate.org> Signed-off-by: Максим Горпиніч <gorpinicmaksim0@gmail.com> Translate-URL: https://hosted.weblate.org/projects/organicmaps/android-typestrings/be/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/android/el/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/android/eu/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/android/uk/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/android/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/countries/zh_Hans/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/ios-typestrings/be/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/ios/el/ Translate-URL: https://hosted.weblate.org/projects/organicmaps/ios/uk/

Signed-off-by: kavikhalique <kavikhalique3@gmail.com>

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

The bug is quite rare and happens when the user taps on the edit (pencil) button on the PlacePage. It seems like the tap happens during the PP data object reloading the and the object type has changed. It is better to avoid failing in such cases because we cannot prevent user interaction during the pp reloading. Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

> При уходе с тропы если язык подсказок русский, говорит - «преращик маршрута». Signed-off-by: Alexander Borsuk <me@alex.bio>

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Windows is performing path normalization anyways. Fixes some unit tests that expect the output to contain forward slashes. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

It's going to be maximized anyway.

github-actions · 2025-08-06T20:02:05Z

@@ -227,15 +227,15 @@ void AsciiToUpper(std::string & s)

 void Trim(std::string & s)
 {
-  boost::trim_if(s, ::isspace);
+  boost::trim_if(s, [](unsigned char c){ return std::isspace(c); });


[clang-format] _{reported by reviewdog 🐶}

Suggested change

boost::trim_if(s, [](unsigned char c){ return std::isspace(c); });

boost::trim_if(s, [](unsigned char c) { return std::isspace(c); });

github-actions · 2025-08-06T20:02:05Z

+    std::tm tmp = tm;
+    return _mkgmtime(&tmp);


[clang-format] _{reported by reviewdog 🐶}

Suggested change

std::tm tmp = tm;

return _mkgmtime(&tmp);

std::tm tmp = tm;

return _mkgmtime(&tmp);

github-actions · 2025-08-06T20:02:05Z

+    std::tm tmp = tm;
+    return _mkgmtime(&tmp);
+#else
+    return timegm(&tm);


[clang-format] _{reported by reviewdog 🐶}

Suggested change

return timegm(&tm);

return timegm(&tm);

github-actions · 2025-08-06T20:02:05Z

@@ -54,7 +54,7 @@ void TransliterateHiraganaToKatakana(UniString & s)

 size_t GetMaxErrorsForToken(UniString const & token)
 {
-  bool const digitsOnly = std::all_of(token.begin(), token.end(), ::isdigit);
+  bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c){ return std::isdigit(c); });


[clang-format] _{reported by reviewdog 🐶}

Suggested change

bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c){ return std::isdigit(c); });

bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c) { return std::isdigit(c); });

github-actions · 2025-08-06T20:02:05Z

@@ -75,6 +75,9 @@ class DesktopLocationService
 #if defined(OMIM_OS_LINUX)
    m_services.push_back(CreateQtLocationService(*this, "geoclue2"));
 #endif                                 // OMIM_OS_LINUX


[clang-format] _{reported by reviewdog 🐶}

Suggested change

#endif // OMIM_OS_LINUX

#endif // OMIM_OS_LINUX

github-actions · 2025-08-06T20:02:06Z

@@ -29,7 +29,7 @@ auto GetNextDayAtNight(int32_t startTimeZoneUTC)
  std::tm * nextDayDate = std::localtime(&nextDay);

  long constexpr kSecondsInHour = 3600;
-  int const curUTCOffset = static_cast<int>(nextDayDate->tm_gmtoff / kSecondsInHour);
+  int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO


[clang-format] _{reported by reviewdog 🐶}

Suggested change

int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO

int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO

github-actions · 2025-08-06T20:02:06Z

-  };
-  dataSource.ForEachInScale(fn, scales::GetUpperScale());
+    int count = 0;
+    auto const fn = [&](FeatureType & ft) {


[clang-format] _{reported by reviewdog 🐶}

Suggested change

auto const fn = [&](FeatureType & ft) {

auto const fn = [&](FeatureType & ft)

{

github-actions · 2025-08-06T20:02:06Z

@@ -25,6 +25,10 @@
 #include <CoreFoundation/CoreFoundation.h>
 #endif

+#ifdef OMIM_OS_WINDOWS
+# include <windows.h>


[clang-format] _{reported by reviewdog 🐶}

Suggested change

# include <windows.h>

#include <windows.h>

github-actions · 2025-08-06T20:02:06Z

@@ -239,7 +239,7 @@ int main(int argc, char * argv[])
 #endif  // BUILD_DESIGNER

    Framework framework(frameworkParams);
-    qt::MainWindow w(framework, std::move(screenshotParams), QApplication::primaryScreen()->geometry()
+    qt::MainWindow w(framework, std::move(screenshotParams)
 #ifdef BUILD_DESIGNER
                                                                 ,


[clang-format] _{reported by reviewdog 🐶}

Suggested change

,

,

github-actions · 2025-08-06T20:03:33Z

-      android:padding="@dimen/margin_quarter_plus">
-      <ImageView
+      android:gravity="center">
+      <LinearLayout


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UseCompoundDrawables: This tag and its children can be replaced by one <TextView/> and a compound drawable

github-actions · 2025-08-06T20:03:33Z

-      android:padding="@dimen/margin_quarter_plus">
-      <ImageView
+      android:gravity="center">
+      <LinearLayout


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UseCompoundDrawables: This tag and its children can be replaced by one <TextView/> and a compound drawable

github-actions · 2025-08-06T20:03:33Z

-      <ImageView
+      android:gravity="center"
+      android:orientation="vertical">
+      <LinearLayout


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UseCompoundDrawables: This tag and its children can be replaced by one <TextView/> and a compound drawable

github-actions · 2025-08-06T20:03:33Z

-      <ImageView
+      android:gravity="center"
+      android:orientation="vertical">
+      <LinearLayout


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UseCompoundDrawables: This tag and its children can be replaced by one <TextView/> and a compound drawable

github-actions · 2025-08-06T20:03:33Z

-        app:tint="?elevationProfilePropIconTint" />
+        android:gravity="center_vertical"
+        android:orientation="horizontal">
+        <ImageView


⚠️ [Android Lint] _{reported by reviewdog 🐶}
ContentDescription: Missing contentDescription attribute on image

github-actions · 2025-08-06T20:03:34Z

  <dimen name="elevation_profile_peek_height">260dp</dimen>
  <dimen name="elevation_profile_chart_min_height">144dp</dimen>
-  <dimen name="elevation_profile_chart_info_min_height">68dp</dimen>
+  <dimen name="elevation_profile_chart_info_min_height">54dp</dimen>


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UnusedResources: The resource R.dimen.elevation_profile_chart_info_min_height appears to be unused

github-actions · 2025-08-06T20:03:34Z

  <dimen name="text_size_body_3">14sp</dimen>
  <dimen name="text_size_body_4">12sp</dimen>
  <dimen name="text_size_body_5">10sp</dimen>
+  <dimen name="text_size_body_6">8sp</dimen>


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UnusedResources: The resource R.dimen.text_size_body_6 appears to be unused

github-actions · 2025-08-06T20:03:34Z

    <item name="android:textColor">?android:textColorSecondary</item>
  </style>

+  <style name="MwmTextAppearance.Body6">


⚠️ [Android Lint] _{reported by reviewdog 🐶}
UnusedResources: The resource R.style.MwmTextAppearance_Body6 appears to be unused

github-actions · 2025-08-06T20:03:34Z

+      android:layout_width="match_parent"
+      android:layout_height="wrap_content"
+      android:background="?ppBackground">
+      <ImageView


⚠️ [Android Lint] _{reported by reviewdog 🐶}
ContentDescription: Missing contentDescription attribute on image

github-actions · 2025-08-06T20:03:35Z

+        android:paddingEnd="@dimen/margin_quarter"
+        android:textAllCaps="false"
+        tools:text="@string/categories" />
+      <ImageView


⚠️ [Android Lint] _{reported by reviewdog 🐶}
ContentDescription: Missing contentDescription attribute on image

The previous port matched ephemeral client ports range and led to failures like this one on Linux CI: ``` 4/35 Test #1: OmimStartTestServer ..............***Failed 0.27 sec Traceback (most recent call last): File "/home/runner/work/organicmaps/organicmaps/tools/python/test_server/start_server.py", line 62, in <module> with urllib.request.urlopen(READY_URL, timeout=1.0) as response: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/urllib/request.py", line 215, in urlopen return opener.open(url, data, timeout) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/urllib/request.py", line 515, in open response = self._open(req, data) ^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/urllib/request.py", line 532, in _open result = self._call_chain(self.handle_open, protocol, protocol + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/urllib/request.py", line 492, in _call_chain result = func(*args) ^^^^^^^^^^^ File "/usr/lib/python3.12/urllib/request.py", line 1373, in http_open return self.do_open(http.client.HTTPConnection, req) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/urllib/request.py", line 1348, in do_open r = h.getresponse() ^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/http/client.py", line 1448, in getresponse response.begin() File "/usr/lib/python3.12/http/client.py", line 336, in begin version, status, reason = self._read_status() ^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3.12/http/client.py", line 318, in _read_status raise BadStatusLine(line) http.client.BadStatusLine: GET /id HTTP/1.1 ``` Signed-off-by: Alexander Borsuk <me@alex.bio>

Osyotr marked this pull request as ready for review April 9, 2024 22:42

Osyotr force-pushed the wip-windows branch 7 times, most recently from 7e87848 to 7ea5d3d Compare April 9, 2024 23:40

Osyotr mentioned this pull request Apr 12, 2024

Windows builds TODO organicmaps/organicmaps#7842

Open

18 tasks

Osyotr force-pushed the wip-windows branch 11 times, most recently from 55e42d8 to 674eafd Compare May 1, 2024 14:31

Osyotr force-pushed the wip-windows branch from 674eafd to 48cc91a Compare May 22, 2024 23:10

Osyotr force-pushed the wip-windows branch from 48cc91a to 59459c6 Compare August 17, 2024 11:40

Osyotr force-pushed the wip-windows branch from 59459c6 to a848d5d Compare October 31, 2024 20:49

Osyotr force-pushed the wip-windows branch from a848d5d to ef69582 Compare November 17, 2024 19:40

Osyotr force-pushed the wip-windows branch from ef69582 to 824e0ec Compare December 3, 2024 23:20

Osyotr force-pushed the wip-windows branch from 824e0ec to 528c0fd Compare January 15, 2025 21:13

biodranik and others added 26 commits August 4, 2025 17:10

[android] Show bookmarks names setting

eae93ea

Signed-off-by: Alexander Borsuk <me@alex.bio>

Implement Track Selection and elevation info display on PP

57bcca9

Signed-off-by: kavikhalique <kavikhalique3@gmail.com>

Removed animated slow rendering and Nit picks

b1be6cf

Signed-off-by: kavikhalique <kavikhalique3@gmail.com>

[ios] Disable user interaction on PP vc close

9ecbb19

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

Minor fixes.

05b1382

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>

Added Spline::Equidistant.

e962cd7

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>

[drape] Added basic routes drawing.

908e612

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>

[android] Update active route icons.

2da17b4

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>

Show a toast when routes need maps update.

5a8cd0c

Signed-off-by: Viktor Govako <viktor.govako@gmail.com>

Add initital routes_update_maps_text toast message string

43cb22a

Signed-off-by: Kiryl Kaveryn <kirylkaveryn@gmail.com>

[TTS] Clearer pronouncement of route recalculation in ru

4ca4c48

> При уходе с тропы если язык подсказок русский, говорит - «преращик маршрута». Signed-off-by: Alexander Borsuk <me@alex.bio>

Always use vendored fast_double_parser for now

b4ab793

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Fix some invalid usages of isspace and isdigit

ef8198b

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Always use forward slashes on Windows

26e0bca

Windows is performing path normalization anyways. Fixes some unit tests that expect the output to contain forward slashes. Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Fix some unit tests on Windows

b3b1e67

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

WIP Timey stuff

344f8ad

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

Add CMakePresets.json and integrate with vcpkg

1b32abf

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

WIP windows action

6f11519

Signed-off-by: Osyotr <Osyotr@users.noreply.github.com>

tmp

ae05bb7

WIP protobuf

8fb06ba

Fix QOpenGLContext creation on Windows

a80e856

Don't set geometry for MainWindow

a137933

It's going to be maximized anyway.

test action

ce76308

Osyotr force-pushed the wip-windows branch from 7e66bf8 to ce76308 Compare August 6, 2025 20:00

github-actions Bot reviewed Aug 6, 2025

View reviewed changes

	boost::trim_if(s, [](unsigned char c){ return std::isspace(c); });
	boost::trim_if(s, [](unsigned char c) { return std::isspace(c); });

	bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c){ return std::isdigit(c); });
	bool const digitsOnly = std::all_of(token.begin(), token.end(), [](unsigned char c) { return std::isdigit(c); });

	int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO
	int const curUTCOffset = static_cast<int>(0 / kSecondsInHour); // TODO

	auto const fn = [&](FeatureType & ft) {
	auto const fn = [&](FeatureType & ft)
	{

Conversation

Osyotr commented Apr 9, 2024

Uh oh!

vaanwd commented Nov 17, 2024

Uh oh!

Osyotr commented Nov 17, 2024

Uh oh!

vaanwd commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Osyotr commented Nov 19, 2024

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

vaanwd commented Nov 19, 2024 •

edited

Loading