RDEV-8923 - Ensure Inner Views are Disposed #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vivokas20
reviewed
Dec 4, 2025
Contributor
Vivokas20
left a comment
Vivokas20
left a comment
There was a problem hiding this comment.
I'm clearly missing some context on this but I don't see any major issue atm
| } | ||
|
|
||
| public override bool ShowDeveloperTools => false; | ||
| public override bool ShowDeveloperTools => true; |
Contributor
There was a problem hiding this comment.
I know this is the Sample.Avalonia but Is this intended or should it be reverted?
|
|
||
| export interface IChildViews { | ||
| ListView: TaskListView; | ||
| ListView: TaskListView |
Contributor
There was a problem hiding this comment.
Suggested change
| ListView: TaskListView | |
| ListView: TaskListView; |
Comment on lines
+117
to
+119
|
|
||
|
|
||
| this.shadowRoot = null; |
Contributor
There was a problem hiding this comment.
Suggested change
| this.shadowRoot = null; | |
| this.shadowRoot = null; |
fmgracias
approved these changes
Dec 9, 2025
Contributor
fmgracias
left a comment
fmgracias
left a comment
There was a problem hiding this comment.
I lack some context but looks ok, good job
| component: React.ReactElement; | ||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
extra line break to remove
| } | ||
|
|
||
| if (frameName === mainFrameName) { | ||
| console.log(`Set ensureDisposeInnerViewsFlag to ${ensureDisposeInnerViews} for main frame`); |
Comment on lines
+18
to
+19
| ? MainModule.GetOrAddChildView<TaskListViewModule>(childViewName) | ||
| : MainModule.GetOrAddChildView<UsersViewModule>(childViewName); |
Contributor
There was a problem hiding this comment.
context regarding these two type of views pls
Contributor
There was a problem hiding this comment.
ah this is the sample, nvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.