chore(RDGRS-1371): add new flow layer #132
Conversation
OS-kiranmalsetty
commented
May 6, 2025
•
OS-kiranmalsetty
commented
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
main.go
Outdated
| @@ -150,7 +153,12 @@ func client(args []string) { | |||
|
|
|||
| queryParams := generateQueryParameters(localPorts) | |||
|
|
|||
| config.Server = fmt.Sprintf("%s%s", args[0], queryParams) | |||
| //get server URL | |||
| restyclient := resty.New() | |||
There was a problem hiding this comment.
why not inside the func getURL
There was a problem hiding this comment.
I created the client outside the getURL to test the function with the mocked client.
main.go
Outdated
| //get server URL | ||
| restyclient := resty.New() | ||
| //httpClient := &http.Client{} | ||
| ServerURL := getURL(restyclient, args[0]) |
There was a problem hiding this comment.
ServerURL, why upper case?
There was a problem hiding this comment.
must be a typo. Fixed it.
main.go
Outdated
| @@ -180,6 +188,36 @@ func client(args []string) { | |||
| } | |||
| } | |||
|
|
|||
| func getURL(client *resty.Client, requestLocation string) string { | |||
There was a problem hiding this comment.
getURL it's not the best name
There was a problem hiding this comment.
Any suggestions for the name?
main.go
Outdated
| } | ||
|
|
||
| // Ensure the URL has a valid scheme | ||
| if parsedURL.Scheme != "http" && parsedURL.Scheme != "https" { |
There was a problem hiding this comment.
Without a scheme should be allowed, like localhost:8080
|
|
||
| resp, err := client.SetDoNotParseResponse(true).R().Get(parsedURL.String()) | ||
| if err != nil { | ||
| if resp != nil && resp.StatusCode() == http.StatusFound { |
There was a problem hiding this comment.
why validate if resp != nil twice?
There was a problem hiding this comment.
resp and err are different fields. I want to check the response only when there is an error.
