update - #4
Merged
Merged
Conversation
added 6 commits
April 21, 2026 12:54
…Layout Moves /address-search under the MapLayout route so the persistent Google Map stays mounted across navigation instead of being torn down and rebuilt. AddressSearchMain now drives the shared map via MapContext (setConfig/setOverlays/panTo/layerMode) rather than embedding its own <APIProvider>/<Map>. Also: - Switch MapLayout to the real Google Cloud mapId (enables Advanced Markers and styled map rendering) - Set APIProvider language="iw" region="IL" so Places/Geocoding return Hebrew results and IL-biased suggestions
The home pin used a wrapper transform: translate(0, -50%) to fake the stem tip sitting on the address. AdvancedMarker anchors the content box, not the transformed visual, so the pin drifted away from the true lat/lng at different zoom levels. Remove the transform and rely on AdvancedMarker's default anchoring (bottom-center of content on coord), which puts the stem tip on the address at every zoom. Also wire onClick on the home marker to navigate to /address-search with the user's full home address payload (lat/lng + city/street/house), mirroring the route the top-search autocomplete already uses. Applied on MainScreen and NearbyReportsScreen.
…k failures Map login failure by HTTP status: - 401 -> "סיסמא או שם משתמש לא נכונים" - 0/undefined (network) -> "לא ניתן להתחבר לשרת, נסו שוב מאוחר יותר" - 5xx -> "שגיאת שרת, נסו שוב בעוד מספר רגעים" - other -> fall back to the error message, or a generic login error Replaces the catch-all that leaked raw backend messages (or bare "שגיאה בהתחברות") for wrong-password attempts.
…pacitor-app dependency
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Ovalvoi
pushed a commit
that referenced
this pull request
May 18, 2026
- Add `permissions: contents: read` (+ `security-events: write` for CI) to all four workflow files so they run with least-privilege tokens instead of the default over-broad GITHUB_TOKEN permissions. - Sanitize `context.Request.Path` before logging in ExceptionHandlingMiddleware to prevent log-forging via CR/LF injection. - Dismiss false-positive CodeQL alerts: #13 (AuthController UserId log is not PII) and #10 (ImageUploadModal preview is a blob URL, not HTML). - Dismiss secret-scanning alerts #4/#5/#6: Firebase API keys are intentionally public and restricted via Firebase Security Rules / Google Cloud Console; they are not server-side credentials.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.