Skip to content

POC : add consumer webRTC stream into liveKit and not in player#20

Open
nums wants to merge 1 commit into
OvenMediaLabs:mainfrom
nums:feat-add-consume
Open

POC : add consumer webRTC stream into liveKit and not in player#20
nums wants to merge 1 commit into
OvenMediaLabs:mainfrom
nums:feat-add-consume

Conversation

@nums

@nums nums commented Aug 8, 2024

Copy link
Copy Markdown
  • Split logic in different objects
  • Add Consume feature
  • Create a demo page to be able to send and receive stream

@SangwonOh SangwonOh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen some nice new features and well-organized code.

However, the interface has changed so much that it's hard to merge it into the current version.

If the same features are implemented while maintaining the current interface, it might be possible to merge it.

Thank you for your contribution.

@nums

nums commented Oct 25, 2024

Copy link
Copy Markdown
Author

Hello, ok, I that it's possible, I will check and update PR in this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants