Skip to content

fix(sbpf): disagreements with FD fixtures#216

Open
sonicfromnewyoke wants to merge 1 commit intoOverclock-Validator:devfrom
sonicfromnewyoke:sonic/check-sbpf
Open

fix(sbpf): disagreements with FD fixtures#216
sonicfromnewyoke wants to merge 1 commit intoOverclock-Validator:devfrom
sonicfromnewyoke:sonic/check-sbpf

Conversation

@sonicfromnewyoke
Copy link

Problem

sbpf package has a lot of disagreements with FD fixtures

Summary of Changes

  • match logic with FD
  • fix all the disagreements from FD fixtures. Conformance rate 29.9% -> 100%

output of make test-conformance-elf command:

go test ./conformance/ -run TestConformance_ElfLoader_Firedancer -v
=== RUN   TestConformance_ElfLoader_Firedancer
    elf_loader_fb_test.go:57: Found 953 ELF loader fixtures
    elf_loader_fb_test.go:179: 
        === ELF Loader Conformance Results ===
    elf_loader_fb_test.go:180: Total fixtures:     953
    elf_loader_fb_test.go:181: Parse errors:       0
    elf_loader_fb_test.go:182: Both pass:          742
    elf_loader_fb_test.go:183: Both fail:          211
    elf_loader_fb_test.go:184: False pass (bad):   0 (mithril loads, fixture rejects)
    elf_loader_fb_test.go:185: False fail (bad):   0 (mithril rejects, fixture loads)
    elf_loader_fb_test.go:186: Panics (crash bug): 0
    elf_loader_fb_test.go:187: Entry PC match:     742 / 742
    elf_loader_fb_test.go:188: Text count match:   742 / 742
    elf_loader_fb_test.go:212: 
        Conformance rate: 100.0% (953/953)
--- PASS: TestConformance_ElfLoader_Firedancer (0.16s)
PASS
ok      github.com/Overclock-Validator/mithril/conformance      0.499s

cc @smcio @7layermagik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant