fix(sbpf): disagreements with FD fixtures#216
Open
sonicfromnewyoke wants to merge 1 commit intoOverclock-Validator:devfrom
Open
fix(sbpf): disagreements with FD fixtures#216sonicfromnewyoke wants to merge 1 commit intoOverclock-Validator:devfrom
sonicfromnewyoke wants to merge 1 commit intoOverclock-Validator:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sbpf package has a lot of disagreements with FD fixtures
Summary of Changes
output of
make test-conformance-elfcommand:go test ./conformance/ -run TestConformance_ElfLoader_Firedancer -v === RUN TestConformance_ElfLoader_Firedancer elf_loader_fb_test.go:57: Found 953 ELF loader fixtures elf_loader_fb_test.go:179: === ELF Loader Conformance Results === elf_loader_fb_test.go:180: Total fixtures: 953 elf_loader_fb_test.go:181: Parse errors: 0 elf_loader_fb_test.go:182: Both pass: 742 elf_loader_fb_test.go:183: Both fail: 211 elf_loader_fb_test.go:184: False pass (bad): 0 (mithril loads, fixture rejects) elf_loader_fb_test.go:185: False fail (bad): 0 (mithril rejects, fixture loads) elf_loader_fb_test.go:186: Panics (crash bug): 0 elf_loader_fb_test.go:187: Entry PC match: 742 / 742 elf_loader_fb_test.go:188: Text count match: 742 / 742 elf_loader_fb_test.go:212: Conformance rate: 100.0% (953/953) --- PASS: TestConformance_ElfLoader_Firedancer (0.16s) PASS ok github.com/Overclock-Validator/mithril/conformance 0.499scc @smcio @7layermagik