Skip to content

[BUG] Fix license field validation failures#58

Merged
Francisco Jiménez (jjcfrancisco) merged 2 commits into
mainfrom
jjcfrancisco/fix-stac-license-validation
May 13, 2026
Merged

[BUG] Fix license field validation failures#58
Francisco Jiménez (jjcfrancisco) merged 2 commits into
mainfrom
jjcfrancisco/fix-stac-license-validation

Conversation

@jjcfrancisco
Copy link
Copy Markdown
Member

@jjcfrancisco Francisco Jiménez (jjcfrancisco) commented May 13, 2026

Fixes four license field failures causing CI STAC validation to fail.

  • Remove leading tab from land_cover value
  • Add missing building_partODbL-1.0
  • Change place and address to "other" (multi-license, no single SPDX ID) with a rel=license link per STAC spec

Signed-off-by: Francisco Jiménez <jjcfrank@gmail.com>
@jjcfrancisco Francisco Jiménez (jjcfrancisco) added the bug Something isn't working label May 13, 2026
@jjcfrancisco Francisco Jiménez (jjcfrancisco) linked an issue May 13, 2026 that may be closed by this pull request
@jjcfrancisco Francisco Jiménez (jjcfrancisco) marked this pull request as ready for review May 13, 2026 10:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

🗺️ OMF STAC preview is live!

📦 Catalog https://staging.overturemaps.org/stac/pr/58/catalog.json
🕐 Updated May 13, 2026 13:48 UTC
📝 Commit 850b400

Note

♻️ This preview updates automatically with each push to this PR.

Copy link
Copy Markdown
Contributor

@lowlydba John McCall (lowlydba) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Can you add one small change to remove this line:

allowed-to-fail: "stac-validate" #TODO: Remove after issues #48, 49, 50, 51 are resolved and this passes

That way the stac linter becomes a blocking status check now that we're passing 🎉

Signed-off-by: Francisco Jiménez <jjcfrank@gmail.com>
Copy link
Copy Markdown
Contributor

@lowlydba John McCall (lowlydba) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jjcfrancisco Francisco Jiménez (jjcfrancisco) merged commit daba271 into main May 13, 2026
15 checks passed
@jjcfrancisco Francisco Jiménez (jjcfrancisco) deleted the jjcfrancisco/fix-stac-license-validation branch May 13, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix STAC license

2 participants