Update leaflet to 1.9.4 and carto to 5.8.0 #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes openstreetmap-carto/openstreetmap-carto#4468 and thus allows to work around issue Overv#244 via local file downloads
files are now in a sub-dir "dist" in the download-package
centic9
commented
Dec 10, 2023
| && git clone --single-branch --branch v5.4.0 https://github.com/gravitystorm/openstreetmap-carto.git --depth 1 \ | ||
| && git clone --single-branch --branch v5.8.0 https://github.com/gravitystorm/openstreetmap-carto.git --depth 1 \ | ||
| && cd openstreetmap-carto \ | ||
| && sed -i 's/, "unifont Medium", "Unifont Upper Medium"//g' style/fonts.mss \ |
Author
There was a problem hiding this comment.
All these font-replacements are not necessary any more now
centic9
commented
Dec 10, 2023
| && wget https://github.com/Leaflet/Leaflet/releases/download/v1.8.0/leaflet.zip \ | ||
| && wget https://github.com/Leaflet/Leaflet/releases/download/v1.9.4/leaflet.zip \ | ||
| && unzip leaflet.zip \ | ||
| && mv dist/* . \ |
Author
There was a problem hiding this comment.
The Zip-Package now contains a sub-dir "dist", so we need to move the content back to the main directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Leaflet to 1.9.4 and openstreetmap-carto to 5.8.0 and adjusts steps in the Dockerfile as necessary.
This then allows to inject file:// URLs to work around download issues discussed in #244