musikr: batch cache writes to reduce fsync overhead on cold scan - #1365
Open
shapeshed wants to merge 1 commit into
Open
musikr: batch cache writes to reduce fsync overhead on cold scan#1365shapeshed wants to merge 1 commit into
shapeshed wants to merge 1 commit into
Conversation
Replace per-song Room inserts with chunked bulk inserts (500 songs per transaction). Reduces ~3000 individual fsync calls to ~6 on a full cold scan, cutting write time from seconds to milliseconds on typical eMMC/UFS storage. Adds writeAll() to MutableCache with a default fallback for external implementors, and unit tests for the chunking behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of changes
Replace per-song Room inserts with chunked bulk inserts (500 songs per transaction). Reduces ~3000 individual fsync calls to ~6 on a full cold scan, cutting write time from seconds to milliseconds on typical eMMC/UFS storage. Adds writeAll() to MutableCache with a default fallback for external implementors, and unit tests for the chunking behaviour.
Fixes the following issues
None. This is a performance improvement
Any additional information
None
APK testing
Due diligence