Docker setup #2
Merged
Docker setup #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backbone of this PR is this other one created by OZ.
Description
In this one, I isolated the docker environment setup so the PR is smaller and easier to review and debug if necessary.
I simplified what Oz already had, optimized some things to build the container faster, and fixed some issues (especially related to the mixing of python venvs and docker's env).
I also added some instructions in the README.
Testing
This setup has already been tested by Andrew, Samson and I. So, in theory, we covered both Windows and Macs. I also tested in both VSCODE and neovim.
To test, you can just follow the instructions in the readme :) (please feel free to provide feedback in case something is confusing / not clear enough)
If everything goes right, you will see some logs printed in the terminal and also a test connection message in the browser:
