WIP convert CommunityRestConf to JaxRsEndpoint #2013
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
2 times, most recently
from
aa22659 to
9e1ebc7
Compare
|
26.3. - Rebased and fixing openapi |
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
3 times, most recently
from
bdd0619 to
d0f4272
Compare
|
OpenApi fixed, now fixing Http2 and Https |
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
from
d0f4272 to
69ef4de
Compare
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
from
69ef4de to
1d05889
Compare
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
from
1d05889 to
424ed33
Compare
This conversion is required in order to use JaxRsEndpoint and JaxRsOpenApi since they do not use regular server but JettyWebServer. This patch basically replaces LightyServerBuilder with JettyServerProvider which makes JettyServer acessible everywhere in Lighty.io where it may be needed. This code contains TODO to convert HTTP2 and HTTPS to JettyWebServer which should be done in separate task due to scale of LIGHTY-329. JIRA: LIGHTY-329 Signed-off-by: tobias.pobocik <[email protected]>
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
2 times, most recently
from
d803f56 to
9371b51
Compare
There is no need to create restconf manually anymore thanks to JaxRsEndpoint. This patch relies on the previous JettyWebServerProvider patch since JaxRsEndpoint requires JettyWebServer instead of regular server. Now initialization order matters, and restconf has to be initialized after lighty services. JIRA: LIGHTY-329 Signed-off-by: tobias.pobocik <[email protected]>
Since JettyWebServer is being used, the entire AAA authorization can be modernized to use WebContext.builder() instead of handlers. Classes related to moon endpoins can also be ditched since now its part ShiroProvider using WebContext.builder(). JIRA: LIGHTY-329 Signed-off-by: tobias.pobocik <[email protected]>
Use the JettyWebServer to initialize OpenApi the same way as its done in ODL. Also add possibility to add WebContextSecurer to secure the /openapi endpoint. JIRA: LIGHTY-329 Signed-off-by: tobias.pobocik <[email protected]>
Tobianas
force-pushed
the
reworkCommunityRestConf
branch
from
9371b51 to
39eca7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also required us to convert LightyServerBuilder to use JettyWebServer since it is used in CommunityRestConf to initialize JaxRsEndpoint.