Draft of code movement from GH lighty to ODL gerrit

[ihrasko]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ihrasko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request represents a substantial code cleanup and migration effort, moving various gNMI-related features, OpenConfig models, and core gNMI modules out of the current repository. The changes suggest a consolidation or relocation of these components to a different development environment, likely from a 'lighty' project to an 'ODL gerrit' system, as indicated by the title. The removal impacts build configurations, YANG definitions, and Java source code across multiple functional areas.

Highlights

• Project Restructuring: A significant portion of the gNMI-related modules and OpenConfig models have been removed, indicating a major restructuring or migration of this codebase.
• Module Deletion: Several top-level Maven modules, including 'features-gnmi', 'odl-gnmi', 'gnmi-parent', and 'gnmi-karaf', along with their associated pom.xml files, have been entirely removed.
• OpenConfig Model Removal: A comprehensive set of OpenConfig YANG models and their corresponding Maven project files under lighty-models/openconfig-models have been deleted. This includes models for AAA, Alarms, Interfaces (Ethernet, Aggregate), Inet Types, License, Messages, OpenFlow, Platform, Procmon, System, and VLAN.
• gNMI Internal Component Removal: Core gNMI internal components, such as lighty-gnmi-commons, lighty-gnmi-connector, and lighty-gnmi-device-simulator, including their Java source files, test resources, and build configurations, have been removed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be part of a large-scale code migration, removing a significant number of files related to gNMI functionality from the repository. The deletions cover features, parent POMs, Karaf packaging, YANG models (for gNMI, gNOI, and OpenConfig), and the corresponding Java source code for connectors and simulators.

Given that this is a draft and consists entirely of file deletions, a detailed code review is not applicable. However, it's important to note that this change, in isolation, will likely break the build. Several parent pom.xml files in the repository still reference the deleted modules (e.g., features, gnmi-parent, karaf in the root pom.xml, and various sub-modules within lighty-modules and lighty-models). These references will need to be removed to ensure the project remains buildable. This is likely planned for a subsequent commit, but it's a critical point to ensure the integrity of the repository.