Close initialized NettyRestConf bundles

[PeterSuna]

Call close on initialized NettyRestConf bundles within the stopProcedure method.
Clean up parameters and attributes.

[gemini-code-assist]

Summary of Changes

Hello @PeterSuna, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the shutdown process of the NettyRestConf bundle by ensuring that all initialized resources are properly closed when the module stops. This prevents potential resource leaks and improves the overall stability and reliability of the application during module lifecycle management, making the system more robust.

Highlights

• Resource Cleanup: The stopProcedure method now explicitly closes MdsalRestconfStreamRegistry, MdsalRestconfServer, and MdsalDatabindProvider instances, in addition to the NettyEndpoint.
• Field Promotion: MdsalDatabindProvider and MdsalRestconfServer are promoted from local variables within initProcedure to class-level fields to make them accessible for proper cleanup in stopProcedure.
• Robust Shutdown: The stopProcedure now includes null checks for resources before attempting to close them and tracks the overall success of the shutdown process more comprehensively.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to properly close initialized Netty RESTCONF bundles during shutdown. The changes involve moving MdsalDatabindProvider and MdsalRestconfServer from local variables to class fields so they can be accessed and closed in the stopProcedure method. The stopProcedure is updated to close these resources, along with nettyEndpoint and mdsalRestconfStreamRegistry.

My review focuses on improving the robustness of the resource cleanup process. I've suggested a change in stopProcedure to ensure that all resources are attempted to be closed, even if one of the close() operations fails. This prevents potential resource leaks. I've also recommended adjusting the final log message to accurately reflect the outcome of the shutdown process.