Skip to content

Conversation

@ihrasko
Copy link
Collaborator

@ihrasko ihrasko commented Dec 12, 2025

Current latest netconf-node-optional revision is 2022-12-25.

JIRA: LIGHTY-408

(cherry picked from commit a709859)

Current latest netconf-node-optional revision is 2022-12-25.

JIRA: LIGHTY-408
Signed-off-by: Peter Suna <[email protected]>
(cherry picked from commit a709859)
@ihrasko ihrasko merged commit 7060186 into PANTHEONtech:22.x Dec 12, 2025
4 of 6 checks passed
@ihrasko ihrasko deleted the 22.x-fixNodeOptionalRev branch December 12, 2025 09:22
@gemini-code-assist
Copy link

Summary of Changes

Hello @ihrasko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in the "netconf-node-optional" module's revision number within various sample configuration JSON files. By updating the revision to the correct "2022-12-25" version, the change ensures that the example configurations accurately reflect the latest available module definition, preventing potential compatibility issues or confusion for users relying on these samples.

Highlights

  • NETCONF Module Revision Update: The revision for the "netconf-node-optional" module has been corrected from "2024-06-11" to "2022-12-25" across several sample configuration files, aligning with its actual latest version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the revision for netconf-node-optional to 2022-12-25 in four sample JSON configuration files. This change correctly aligns the configuration with the YANG module revision defined in the codebase, as confirmed by the NetconfConfigUtils.java file. The fix is necessary for consistency and correctness of the sample configurations. The changes are accurate and I have no further comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants