Conversation
https://github.com/spring-projects/spring-boot/releases/tag/v3.5.12 Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech> (cherry picked from commit 9fab116)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Spring Boot version from 3.5.11 to 3.5.12 across multiple POM files. The review feedback correctly identifies that version 3.5.12 is likely non-existent, which would lead to build failures, and suggests centralizing the version management via Maven properties to improve maintainability.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-dependencies</artifactId> | ||
| <version>3.5.11</version> | ||
| <version>3.5.12</version> |
There was a problem hiding this comment.
The specified Spring Boot version 3.5.12 does not appear to be a valid, released version. Using a non-existent version will cause the build to fail when Maven attempts to resolve this dependency. Please update this to a correct and available Spring Boot version.
On a related note, to improve maintainability, consider defining the Spring Boot version as a Maven property in a parent POM. This would centralize the version number, making future updates easier and less error-prone, especially since this version is used in multiple modules.
There was a problem hiding this comment.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.5.11</version> | ||
| <version>3.5.12</version> |
There was a problem hiding this comment.
The Spring Boot parent version 3.5.12 seems to be incorrect, as there is no such version released. This will cause the build to fail. Please correct this to a valid Spring Boot version.
To improve project maintainability, it is a good practice to manage dependency versions in a centralized manner. Using properties in a parent POM or a Bill of Materials (BOM) for key dependencies like Spring Boot can help ensure consistency and simplify updates across the project.
There was a problem hiding this comment.
2 participants
https://github.com/spring-projects/spring-boot/releases/tag/v3.5.12
(cherry picked from commit 9fab116)